[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Undo redo framework for text refactored
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2012-02-24 12:21:48
Message-ID: 20120224122148.17257.52562 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 24, 2012, 11:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoTextEditor.cpp, lines 1891-1900
> > <http://git.reviewboard.kde.org/r/104047/diff/1/?file=50772#file50772line1891>
> >
> > This code block is duplicated quite often. I think it makes sense to re-factor \
> > this so it can be reused e.g.
> > startCommand(i18nc(...));
> >
> > The same can be done for endCommand
> >
> > However this change can also work to a later state
Indeed. We made the same conclusion. However the patch is already quite large so it \
will be a followup as you also hint at.
> On Feb. 24, 2012, 11:58 a.m., Thorsten Zachmann wrote:
> > words/part/KWDocument.h, line 271
> > <http://git.reviewboard.kde.org/r/104047/diff/1/?file=50793#file50793line271>
> >
> > Is it enough to do that only for Words?
Yesit's only used if there is an anchor and only words adds anchors. However if say \
stage were to start having anchors it would be needed in stage too
> On Feb. 24, 2012, 11:58 a.m., Thorsten Zachmann wrote:
> > libs/flake/commands/KoShapeDeleteCommand.cpp, lines 27-28
> > <http://git.reviewboard.kde.org/r/104047/diff/1/?file=50767#file50767line27>
> >
> > This seems not to be needed please remvoe.
Actually having kdebug included for easy use is quite convenient so we left it in. \
But sure.
- C.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104047/#review10863
-----------------------------------------------------------
On Feb. 23, 2012, 12:10 p.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104047/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2012, 12:10 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> We have made changes to the undo framework in kotexteditor to make things work.
> The DeleteCommand has become much more capable as it handles complex selections and \
> bookmarks now The KoTextEditor.cpp file has been split out into 3 files
> The StyleChange commands and shapeAnchoring commands have been adapted to the new \
> frame work
>
> Diffs
> -----
>
> libs/flake/KoShapeController.h abc4358
> libs/flake/commands/KoShapeDeleteCommand.cpp 519f047
> libs/kotext/CMakeLists.txt 567649b
> libs/kotext/KoTextDocument.h 56f55e6
> libs/kotext/KoTextDocument.cpp 5608860
> libs/kotext/KoTextEditor.h 689051b
> libs/kotext/KoTextEditor.cpp 3c141c7
> libs/kotext/KoTextEditor_format.cpp PRE-CREATION
> libs/kotext/KoTextEditor_p.h 77725f3
> libs/kotext/KoTextEditor_undo.cpp PRE-CREATION
> libs/kotext/commands/ChangeAnchorPropertiesCommand.h 4206bb8
> libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp 7d4b912
> libs/kotext/commands/ChangeStylesCommand.h accfd31
> libs/kotext/commands/ChangeStylesCommand.cpp b9fa725
> libs/kotext/commands/ChangeStylesMacroCommand.cpp 34c3822
> libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 89edde1
> libs/kotext/commands/DeleteAnchorsCommand.cpp 621829f
> libs/kotext/commands/DeleteCommand.h 89b448a
> libs/kotext/commands/DeleteCommand.cpp 2a4527d
> libs/kotext/commands/TextPasteCommand.cpp 6b9de68
> libs/kotext/tests/TestKoTextEditor.cpp bd15b3a
> libs/kundo2/kundo2stack.h c0539fe
> libs/kundo2/kundo2stack.cpp 48d6625
> libs/main/rdf/KoSemanticStylesheet.cpp 7853dd0
> libs/main/tests/rdf_test.cpp fb57a5e
> plugins/textshape/TextTool.cpp ddfe47f
> plugins/textshape/commands/TextCutCommand.cpp bdb8eea
> words/part/KWDocument.h 0005bc6
> words/part/KWDocument.cpp 8e00cb6
> words/part/dialogs/KWAnchoringProperties.cpp c742e26
> words/part/dialogs/KWFrameDialog.cpp 0fcc0b7
> words/part/frames/KWTextFrameSet.cpp ebd532f
>
> Diff: http://git.reviewboard.kde.org/r/104047/diff/
>
>
> Testing
> -------
>
> We have played around with undo redo in all the cases we knew were failing and \
> quite a lot of other tests. Undo of many things are still not implemented, but that \
> is not really what this is about. It's about the basic undo, and getting the \
> framework right. Fixing undo of individual stuff can always be done as bug fixes \
> One issue we have noted is insertion of table, whic we believe is a qt bug. We have \
> one last workaround in our minds, but other than that we will just have to wait for \
> a qt fix
>
> Thanks,
>
> C. Boemann
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104047/">http://git.reviewboard.kde.org/r/104047/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 24th, 2012, 11:58 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104047/diff/1/?file=50767#file50767line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/flake/commands/KoShapeDeleteCommand.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <KDebug></span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems not to be \
needed please remvoe.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually \
having kdebug included for easy use is quite convenient so we left it in. But \
sure.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 24th, 2012, 11:58 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104047/diff/1/?file=50772#file50772line1891" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kotext/KoTextEditor.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoTextEditor::splitTableCells()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1234</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">hasSelection</span> <span class="o">=</span> \
<span class="n">d</span><span class="o">-></span><span class="n">caret</span><span \
class="p">.</span><span class="n">hasSelection</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1235</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">hasSelection</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1236</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">updateState</span><span \
class="p">(</span><span class="n">KoTextEditor</span><span class="o">::</span><span \
class="n">Private</span><span class="o">::</span><span class="n">Custom</span><span \
class="p">,</span> <span class="n">i18nc</span><span class="p">(</span><span \
class="s">"(qtundo-format)"</span><span class="p">,</span> <span \
class="s">"Insert Endnote"</span><span class="p">));</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1237</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1238</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1239</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KUndo2Command</span> <span class="o">*</span><span \
class="n">topCommand</span> <span class="o">=</span> <span \
class="n">beginEditBlock</span><span class="p">(</span><span \
class="n">i18nc</span><span class="p">(</span><span \
class="s">"(qtundo-format)"</span><span class="p">,</span> <span \
class="s">"Insert Endnote"</span><span class="p">));</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1240</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">deleteChar</span><span class="p">(</span><span class="kc">false</span><span \
class="p">,</span> <span class="n">topCommand</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1241</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">caret</span><span \
class="p">.</span><span class="n">beginEditBlock</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1242</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1243</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This code block is \
duplicated quite often. I think it makes sense to re-factor this so it can be reused \
e.g.
startCommand(i18nc(...));
The same can be done for endCommand
However this change can also work to a later state</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed. We \
made the same conclusion. However the patch is already quite large so it will be a \
followup as you also hint at.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 24th, 2012, 11:58 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104047/diff/1/?file=50793#file50793line271" \
style="color: black; font-weight: bold; text-decoration: \
underline;">words/part/KWDocument.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">271</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KoShapeController</span> <span class="o">*</span><span \
class="n">m_shapeController</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it enough to do that \
only for Words?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yesit's \
only used if there is an anchor and only words adds anchors. However if say stage \
were to start having anchors it would be needed in stage too</pre> <br />
<p>- C.</p>
<br />
<p>On February 23rd, 2012, 12:10 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2012, 12:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We have made changes to the undo framework in kotexteditor to make \
things work. The DeleteCommand has become much more capable as it handles complex \
selections and bookmarks now The KoTextEditor.cpp file has been split out into 3 \
files The StyleChange commands and shapeAnchoring commands have been adapted to the \
new frame work</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We have played around with undo redo in all the cases we knew were \
failing and quite a lot of other tests. Undo of many things are still not \
implemented, but that is not really what this is about. It's about the basic \
undo, and getting the framework right. Fixing undo of individual stuff can always be \
done as bug fixes One issue we have noted is insertion of table, whic we believe is a \
qt bug. We have one last workaround in our minds, but other than that we will just \
have to wait for a qt fix</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShapeController.h <span style="color: grey">(abc4358)</span></li>
<li>libs/flake/commands/KoShapeDeleteCommand.cpp <span style="color: \
grey">(519f047)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(567649b)</span></li>
<li>libs/kotext/KoTextDocument.h <span style="color: grey">(56f55e6)</span></li>
<li>libs/kotext/KoTextDocument.cpp <span style="color: grey">(5608860)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(689051b)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(3c141c7)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextEditor_p.h <span style="color: grey">(77725f3)</span></li>
<li>libs/kotext/KoTextEditor_undo.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.h <span style="color: \
grey">(4206bb8)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp <span style="color: \
grey">(7d4b912)</span></li>
<li>libs/kotext/commands/ChangeStylesCommand.h <span style="color: \
grey">(accfd31)</span></li>
<li>libs/kotext/commands/ChangeStylesCommand.cpp <span style="color: \
grey">(b9fa725)</span></li>
<li>libs/kotext/commands/ChangeStylesMacroCommand.cpp <span style="color: \
grey">(34c3822)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: \
grey">(89edde1)</span></li>
<li>libs/kotext/commands/DeleteAnchorsCommand.cpp <span style="color: \
grey">(621829f)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: \
grey">(89b448a)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: \
grey">(2a4527d)</span></li>
<li>libs/kotext/commands/TextPasteCommand.cpp <span style="color: \
grey">(6b9de68)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: \
grey">(bd15b3a)</span></li>
<li>libs/kundo2/kundo2stack.h <span style="color: grey">(c0539fe)</span></li>
<li>libs/kundo2/kundo2stack.cpp <span style="color: grey">(48d6625)</span></li>
<li>libs/main/rdf/KoSemanticStylesheet.cpp <span style="color: \
grey">(7853dd0)</span></li>
<li>libs/main/tests/rdf_test.cpp <span style="color: grey">(fb57a5e)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(ddfe47f)</span></li>
<li>plugins/textshape/commands/TextCutCommand.cpp <span style="color: \
grey">(bdb8eea)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(0005bc6)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(8e00cb6)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.cpp <span style="color: \
grey">(c742e26)</span></li>
<li>words/part/dialogs/KWFrameDialog.cpp <span style="color: \
grey">(0fcc0b7)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: \
grey">(ebd532f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104047/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic