[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Can "bool KoStore::open(const QString & _name)" take a path?
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2012-02-15 6:36:11
Message-ID: 201202150736.11549.t.zachmann () zagge ! de
[Download RAW message or body]

Hello Friedrich,

On Wednesday, February 15, 2012 00:23:57 Friedrich W. H. Kossebau wrote:
> Hi,
> 
> reading through OD* writing filters I see two variants to open a file at a
> specifc path for writing. Do both result in the same?
> 
> Filterkpr2odf::convert(...) has:
> 
>     //Save the preview picture
>     output->enterDirectory("Thumbnails");
>     output->open("thumbnail.png");
>     ...
>     output->leaveDirectory();
> 
> Words13OasisGenerator::writePreviewFile() has:
> 
>     m_store->open("Thumbnails/thumbnail.png");
> 

Both result in the same.

> And is the attached patch fixing typos in the path and file name in
> Filterkpr2odf::convert(...) okay to commit? Have not tested it, missing a
> kpr file, simply looks worthwhile to fix.

Haven't tested either but it looks correct. Please fix.

Thorsten
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]