[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Clean a bit calligraconverter.cpp
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2011-12-19 16:33:17
Message-ID: 20111219163317.23252.8183 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 15, 2011, 8:34 a.m., Thorsten Zachmann wrote:
> > tools/converter/calligraconverter.cpp, lines 140-141
> > <http://git.reviewboard.kde.org/r/103413/diff/1/?file=43376#file43376line140>
> >
> > The i18n call needs to be removed as we are in stringfreeze at the moment. Please \
> > add a comment that it should be changed after 2.4 is released.
The i18n was already there I only move it so no i18n freeze is break (it was on line \
172 now it is on 126).
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103413/#review8966
-----------------------------------------------------------
On Dec. 14, 2011, 7:28 p.m., Alex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103413/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2011, 7:28 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Cleaned a little bit calligraconverter.cpp by applying some general code clean \
> concepts such: Return early
> Return on errors
> Do one thing on each function
>
> Is not much change but I think makes code clearer with less indentation etc.
>
>
> Diffs
> -----
>
> tools/converter/calligraconverter.cpp 1baea00
>
> Diff: http://git.reviewboard.kde.org/r/103413/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Fiestas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103413/">http://git.reviewboard.kde.org/r/103413/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 15th, 2011, 8:34 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103413/diff/1/?file=43376#file43376line140" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tools/converter/calligraconverter.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char **argv)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">117</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KUrl</span> <span class="n">uIn</span> <span class="o">=</span> <span \
class="n">args</span><span class="o">-></span><span class="n">url</span><span \
class="p">(</span><span class="mi">0</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">126</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCmdLineArgs</span><span class="o">::</span><span \
class="n">usageError</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Two arguments required"</span><span \
class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">118</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KUrl</span> <span class="n">uOut</span> <span class="o">=</span> <span \
class="n">args</span><span class="o">-></span><span class="n">url</span><span \
class="p">(</span><span class="mi">1</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">127</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="mi">3</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The i18n call needs to \
be removed as we are in stringfreeze at the moment. Please add a comment that it \
should be changed after 2.4 is released.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The i18n \
was already there I only move it so no i18n freeze is break (it was on line 172 now \
it is on 126).</pre> <br />
<p>- Alex</p>
<br />
<p>On December 14th, 2011, 7:28 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2011, 7:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Cleaned a little bit calligraconverter.cpp by applying some general code \
clean concepts such: Return early
Return on errors
Do one thing on each function
Is not much change but I think makes code clearer with less indentation etc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tools/converter/calligraconverter.cpp <span style="color: \
grey">(1baea00)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103413/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic