'Review Request: Clean a bit calligraconverter.cpp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request: Clean a bit calligraconverter.cpp
From:       "Alex Fiestas" <alex () eyeos ! org>
Date:       2011-12-14 19:28:24
Message-ID: 20111214192824.10134.9018 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103413/
-----------------------------------------------------------

Review request for Calligra.

Description
-------

Cleaned a little bit calligraconverter.cpp by applying some general code cl=
ean concepts such:
Return early
Return on errors
Do one thing on each function

Is not much change but I think makes code clearer with less indentation etc.

Diffs
-----

  tools/converter/calligraconverter.cpp 1baea00 =

Diff: http://git.reviewboard.kde.org/r/103413/diff/diff

Testing
-------

Thanks,

Alex Fiestas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103413/">http://git.reviewboard.kde.org/r/103413/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Alex Fiestas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Cleaned a little bit calligraconverter.cpp by applying some \
general code clean concepts such: Return early
Return on errors
Do one thing on each function

Is not much change but I think makes code clearer with less indentation \
etc.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>tools/converter/calligraconverter.cpp <span style="color: \
grey">(1baea00)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103413/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 