[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Review Request: some warnings from clang++
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-11-17 18:43:24
Message-ID: 20111117184324.3280.88881 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103171/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
I'm still not able to compile calligra with clang 2.99.9999, but some meani=
ngful warnings are produced.
Instead of doing a comparation and loose the result, set the value.
Return 0 (as nullptr) instead of false.
Diffs
-----
filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp 4e6d185 =
plan/libs/models/kptnodeitemmodel.cpp 1ecb9f4 =
Diff: http://git.reviewboard.kde.org/r/103171/diff/diff
Testing
-------
still compiles with g++
Thanks,
Jaime Torres Amate
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103171/">http://git.reviewboard.kde.org/r/103171/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm still not able to compile calligra with clang 2.99.9999, but \
some meaningful warnings are produced. Instead of doing a comparation and loose the \
result, set the value. Return 0 (as nullptr) instead of false.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">still compiles with g++</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp <span style="color: \
grey">(4e6d185)</span></li>
<li>plan/libs/models/kptnodeitemmodel.cpp <span style="color: \
grey">(1ecb9f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103171/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic