[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: text:continue-numbering attribute - current support
From: Sebastian Sauer <mail () dipe ! org>
Date: 2011-09-15 19:24:05
Message-ID: 4E7250D5.4010603 () dipe ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On 09/14/2011 04:07 PM, Uzak Matus wrote:
> Hi,
>
> I would like to discuss our support for the text:continue-numbering
> attribute. Its use has been deprecated, but at the moment filters
> miss support for the text:continue-list attribute. It might be
> quicker to modify a bit the current support for text:continue-numbering.
>
> According to ODF:
>
> The text:continue-numbering attribute specifies the numbering of a
> preceding list.
> If the value of the attribute is true and the numbering style of the
> preceding list is the same as the
> current list, the number of the first list item in the current list is
> the number of the last item in the
> preceding list incremented by one.
>
> The most important question first: What do I have to understand under
> numbering style? The whole List style or the attributes of the
> text:list-level-style-number element only? Examples follow, please
> check the current result and the expected one for Example2.
If we do it wrong currently then it's probably not the whole list-style
but only the attributes of the text:list-level-style-number element only
cause atm we take the whole list style into account.
> Consider the text:list-level-style-number element of L1 and L2 to be
> identical.
>
> Example1:
> <text:list text:style-name="L1">
> <text:list-item>
> <text:p text:style-name="P1">List_item1</text:p>
> </text:list-item>
> </text:list>
> <text:list text:style-name="L2" text:continue-numbering="true">
> <text:list-item>
> <text:p text:style-name="P1">List_item2</text:p>
> </text:list-item>
> </text:list>
>
> Result - as displayed by stage:
> 1. List_item1
> 2. List_item2
>
> Example2:
>
> <text:list text:style-name="L1">
> <text:list-item>
> <text:p text:style-name="P1">List_item1</text:p>
> </text:list-item>
> </text:list>
> <text:list text:style-name="L5">
> <text:list-item>
> <text:list>
> <text:list-item>
> <text:p text:style-name="P1">List_item1 - level2</text:p>
> </text:list-item>
> </text:list>
> </text:list-item>
> </text:list>
> <text:list text:style-name="L2" text:continue-numbering="true">
> <text:list-item>
> <text:p text:style-name="P1">List_item2</text:p>
> </text:list-item>
> </text:list>
>
> Result - as displayed by stage:
> 1. List_item1
> 1. List_item1 - level2
> 1. List_item2
>
> Expected result:
> 1. List_item1
> 1. List_item1 - level2
> 2. List_item2
>
Sounds like the
if (otherFormat.style() == format.style()) {
condition at ListItemsHelper.cpp:260 is wrong / not enough then.
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 09/14/2011 04:07 PM, Uzak Matus wrote:
<blockquote
cite="mid:2EA4ACC28971A64F81A9E20A67D13C27179936E7@HKIMAIL01.ixonos.local"
type="cite">
<meta http-equiv="Context-Type" content="text/html;
charset=iso-8859-1">
<div>Hi,<br>
<br>
I would like to discuss our support for the
text:continue-numbering attribute. Its use has been deprecated,
but at the moment filters miss support for the
text:continue-list attribute. It might be quicker to modify a
bit the current support for text:continue-numbering.<br>
<br>
According to ODF:<br>
<br>
The text:continue-numbering attribute specifies the numbering of
a preceding list.<br>
If the value of the attribute is true and the numbering style of
the preceding list is the same as the<br>
current list, the number of the first list item in the current
list is the number of the last item in the<br>
preceding list incremented by one.<br>
<br>
The most important question first: What do I have to understand
under numbering style? The whole List style or the attributes
of the text:list-level-style-number element only? Examples
follow, please check the current result and the expected one for
Example2.
<br>
</div>
</blockquote>
<br>
If we do it wrong currently then it's probably not the whole
list-style but only the attributes of the
text:list-level-style-number element only cause atm we take the
whole list style into account.<br>
<br>
<blockquote
cite="mid:2EA4ACC28971A64F81A9E20A67D13C27179936E7@HKIMAIL01.ixonos.local"
type="cite">
<div>
Consider the text:list-level-style-number element of L1 and L2
to be identical. <br>
<br>
<span>Example1:</span><br>
<text:list text:style-name="L1"><br>
<text:list-item><br>
<text:p
text:style-name="P1">List_item1</text:p><br>
</text:list-item><br>
</text:list><br>
<text:list text:style-name="L2"
text:continue-numbering="true"><br>
<text:list-item><br>
<text:p
text:style-name="P1">List_item2</text:p><br>
</text:list-item><br>
</text:list><br>
<br>
<span>Result - as displayed by stage:</span><br>
1. List_item1<br>
2. List_item2<br>
<br>
<span>Example2:</span><br>
<br>
<text:list text:style-name="L1"><br>
<text:list-item><br>
<text:p
text:style-name="P1">List_item1</text:p><br>
</text:list-item><br>
</text:list><br>
<text:list text:style-name="L5"><br>
<text:list-item><br>
<text:list><br>
\
<text:list-item><br>
\
<text:p text:style-name="P1">List_item1 - level2</text:p><br>
\
</text:list-item><br> \
</text:list><br> </text:list-item><br>
</text:list><br>
<text:list text:style-name="L2"
text:continue-numbering="true"><br>
<text:list-item><br>
<text:p \
text:style-name="P1">List_item2</text:p><br> \
</text:list-item><br> </text:list><br>
<br>
<span>Result - as displayed by stage:</span><br>
1. List_item1<br>
1. List_item1 - level2<br>
1. List_item2<br>
<br>
<span>Expected result: </span><br>
1. List_item1<br>
1. List_item1 - level2<br>
2. List_item2<br>
<br>
</div>
</blockquote>
<br>
Sounds like the<br>
if (otherFormat.style() == format.style()) {<br>
condition at ListItemsHelper.cpp:260 is wrong / not enough then.<br>
<br>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic