'Review Request: Fix crash in slide sorter when one page is bigger'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request: Fix crash in slide sorter when one page is bigger
From:       "Peter Simonsson" <peter.simonsson () gmail ! com>
Date:       2011-08-17 14:57:34
Message-ID: 20110817145734.15149.43850 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102351/
-----------------------------------------------------------

Review request for Calligra.

Summary
-------

The slides sorter crashed on right click outside a page when the page itsel=
f is bigger than the viewport. Also fixed so that a page gets selected on r=
ight click if none is selected already as the code says it should be.

Diffs
-----

  stage/part/KPrSlidesManagerView.cpp 1e3d08e =

Diff: http://git.reviewboard.kde.org/r/102351/diff

Testing
-------

Thanks,

Peter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102351/">http://git.reviewboard.kde.org/r/102351/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Peter Simonsson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The slides sorter crashed on right click outside a page when the page \
itself is bigger than the viewport. Also fixed so that a page gets selected on right \
click if none is selected already as the code says it should be.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>stage/part/KPrSlidesManagerView.cpp <span style="color: \
grey">(1e3d08e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102351/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 