'Review Request: Fix for Words crashes on picking "Blank Document" in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request: Fix for Words crashes on picking "Blank Document" in
From:       "Peter Simonsson" <peter.simonsson () gmail ! com>
Date:       2011-08-07 10:37:36
Message-ID: 20110807103736.7307.6219 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102242/
-----------------------------------------------------------

Review request for Calligra.

Summary
-------

Not one hundred percent sure this is the best way to fix this, but it is that best I could come \
up with.

The crash occurs due to tool options docker trying to access widgets that's already been \
deleted. To avoid this I reset the widgets in the tool options dialog when a new document is \
loaded.

This addresses bug 272410.
    http://bugs.kde.org/show_bug.cgi?id=272410

Diffs
-----

  libs/main/KoDockerManager.h 6e71db6 
  libs/main/KoDockerManager.cpp c893980 
  libs/main/KoMainWindow.cpp c629827 
  libs/main/KoToolDocker.cpp 425497c 
  libs/main/KoToolDocker_p.h e7c373b 

Diff: http://git.reviewboard.kde.org/r/102242/diff

Testing
-------

Thanks,

Peter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102242/">http://git.reviewboard.kde.org/r/102242/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Peter Simonsson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not one hundred \
percent sure this is the best way to fix this, but it is that best I could come up with.

The crash occurs due to tool options docker trying to access widgets that&#39;s already been \
deleted. To avoid this I reset the widgets in the tool options dialog when a new document is \
loaded.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=272410">272410</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/main/KoDockerManager.h <span style="color: grey">(6e71db6)</span></li>

 <li>libs/main/KoDockerManager.cpp <span style="color: grey">(c893980)</span></li>

 <li>libs/main/KoMainWindow.cpp <span style="color: grey">(c629827)</span></li>

 <li>libs/main/KoToolDocker.cpp <span style="color: grey">(425497c)</span></li>

 <li>libs/main/KoToolDocker_p.h <span style="color: grey">(e7c373b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102242/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 