'Review Request: Clean up the tool options widgets'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request: Clean up the tool options widgets
From:       "Peter Simonsson" <peter.simonsson () gmail ! com>
Date:       2011-08-06 18:23:47
Message-ID: 20110806182347.23571.68245 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102234/
-----------------------------------------------------------

Review request for Calligra.

Summary
-------

KarbonCalligraphyOptionWidget:
KarbonPencilTool:
KoZoomToolWidget:
TreeShapeConfigWidget:
Add stretch to make it look good on big screens

KoToolBase:
Don't add a generic window title in the default implementation of createOpt=
ionWidgets as it only duplicates what the docker header says

KoPathTool:
DefaultTool:
Don't first create snapguide widget and set a window title and then create =
a new snapguide widget and add that to the list of widgets to return

KoToolDocker:
Handle empty window titles while creating the layout

ReviewTool:
Don't try to set a layout on a widget that already has a layout

Diffs
-----

  karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp 0c=
e337d =

  karbon/plugins/tools/KarbonPencilTool.cpp 86c8fa5 =

  libs/flake/KoToolBase.cpp 77c039d =

  libs/flake/tools/KoPathTool.cpp 361324e =

  libs/flake/tools/KoZoomToolWidget.ui ed3ba73 =

  libs/main/KoToolDocker.cpp 78c881a =

  plugins/defaultTools/defaulttool/DefaultTool.cpp f54ddd3 =

  plugins/textshape/ReviewTool.cpp 8a1c88c =

  plugins/treeshape/TreeShapeConfigWidget.ui e7e367f =

Diff: http://git.reviewboard.kde.org/r/102234/diff

Testing
-------

Thanks,

Peter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102234/">http://git.reviewboard.kde.org/r/102234/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Peter Simonsson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KarbonCalligraphyOptionWidget: KarbonPencilTool:
KoZoomToolWidget:
TreeShapeConfigWidget:
Add stretch to make it look good on big screens

KoToolBase:
Don&#39;t add a generic window title in the default implementation of createOptionWidgets as it \
only duplicates what the docker header says

KoPathTool:
DefaultTool:
Don&#39;t first create snapguide widget and set a window title and then create a new snapguide \
widget and add that to the list of widgets to return

KoToolDocker:
Handle empty window titles while creating the layout

ReviewTool:
Don&#39;t try to set a layout on a widget that already has a layout</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp <span style="color: \
grey">(0ce337d)</span></li>

 <li>karbon/plugins/tools/KarbonPencilTool.cpp <span style="color: grey">(86c8fa5)</span></li>

 <li>libs/flake/KoToolBase.cpp <span style="color: grey">(77c039d)</span></li>

 <li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(361324e)</span></li>

 <li>libs/flake/tools/KoZoomToolWidget.ui <span style="color: grey">(ed3ba73)</span></li>

 <li>libs/main/KoToolDocker.cpp <span style="color: grey">(78c881a)</span></li>

 <li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: \
grey">(f54ddd3)</span></li>

 <li>plugins/textshape/ReviewTool.cpp <span style="color: grey">(8a1c88c)</span></li>

 <li>plugins/treeshape/TreeShapeConfigWidget.ui <span style="color: grey">(e7e367f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102234/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 