'Re: Review Request: Fix hyperlink-activation in Tables'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Fix hyperlink-activation in Tables
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2011-07-07 13:30:39
Message-ID: 20110707133039.19613.70635 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101872/#review4497
-----------------------------------------------------------

Ship it!

Looks good to me.

- Marijn

On July 7, 2011, 12:47 p.m., Sebastian Sauer wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101872/
> -----------------------------------------------------------
> =

> (Updated July 7, 2011, 12:47 p.m.)
> =

> =

> Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus.
> =

> =

> Summary
> -------
> =

> Sometimes hyperlinks are not proper activated (as in executed if you clic=
k on them so that Konqueror or your favorite Webbrowser surfs to the link o=
r an executable is executed).
> =

> The reason for this are
> a) The logic added with 3b274ee1f4bae850826d694b32885bcc1705dbc5 by Stefa=
n Nikolaus on 2008-07-11 to prevent execution of the hyperlink if the mouse=
-cursor is not over the hyperlink's text was inversed and therefore wrong.
> b) That logic tried to compare the relative to the cell defined coordinat=
es of CellView::textRect with the mouse-position which is in absolute coord=
inates.
> =

> The patch fixes both cases.
> =

> =

> Diffs
> -----
> =

>   tables/ui/HyperlinkStrategy.cpp d35adaf =

> =

> Diff: http://git.reviewboard.kde.org/r/101872/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Sebastian
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101872/">http://git.reviewboard.kde.org/r/101872/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me.</pre>  \
<br />

<p>- Marijn</p>

<br />
<p>On July 7th, 2011, 12:47 p.m., Sebastian Sauer wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus.</div>
<div>By Sebastian Sauer.</div>

<p style="color: grey;"><i>Updated July 7, 2011, 12:47 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sometimes hyperlinks are not proper activated (as in executed if you \
click on them so that Konqueror or your favorite Webbrowser surfs to the link or an \
executable is executed).

The reason for this are
a) The logic added with 3b274ee1f4bae850826d694b32885bcc1705dbc5 by Stefan Nikolaus \
on 2008-07-11 to prevent execution of the hyperlink if the mouse-cursor is not over \
the hyperlink&#39;s text was inversed and therefore wrong. b) That logic tried to \
compare the relative to the cell defined coordinates of CellView::textRect with the \
mouse-position which is in absolute coordinates.

The patch fixes both cases.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tables/ui/HyperlinkStrategy.cpp <span style="color: grey">(d35adaf)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101872/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 