'Re: Review Request: Fixes 274118 and couple of other fixes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Fixes 274118 and couple of other fixes
From:       "Gopalakrishna Bhat" <gopalakbhat () gmail ! com>
Date:       2011-06-11 20:17:59
Message-ID: 20110611201759.7615.54013 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101500/
-----------------------------------------------------------

(Updated June 11, 2011, 8:17 p.m.)

Review request for Calligra, Thorsten Zachmann and Casper Boemann.

Changes
-------

Update to reflect the changes in the repository(mainly the improvements by Zagge to the lists layouting).

Summary
-------

This fixes bugs 274118 and 244345. This also fixes the broken list label alignment feature. 

This addresses bugs 244345 and 274118.
    http://bugs.kde.org/show_bug.cgi?id=244345
    http://bugs.kde.org/show_bug.cgi?id=274118

Diffs (updated)
-----

  libs/kotext/KoText.cpp 8b1bdde 
  libs/kotext/styles/KoListLevelProperties.cpp 6f02874 
  libs/kotext/styles/KoListStyle.h aeb0e47 
  libs/textlayout/KoTextLayoutArea.cpp f57958a 
  libs/textlayout/KoTextLayoutArea_paint.cpp ec70381 
  libs/textlayout/ListItemsHelper.cpp 90f82a7 
  plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 97ee24a 
  plugins/textshape/dialogs/ParagraphIndentSpacing.h 3ea8323 
  plugins/textshape/dialogs/ParagraphIndentSpacing.cpp bb4c224 

Diff: http://git.reviewboard.kde.org/r/101500/diff

Testing
-------

Thanks,

Gopalakrishna

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101500/">http://git.reviewboard.kde.org/r/101500/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra, Thorsten Zachmann and Casper Boemann.</div>
<div>By Gopalakrishna Bhat.</div>

<p style="color: grey;"><i>Updated June 11, 2011, 8:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update to reflect the changes in the repository(mainly the improvements \
by Zagge to the lists layouting).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes bugs 274118 and 244345. This also fixes the broken list label \
alignment feature. </pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=244345">244345</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=274118">274118</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/kotext/KoText.cpp <span style="color: grey">(8b1bdde)</span></li>

 <li>libs/kotext/styles/KoListLevelProperties.cpp <span style="color: \
grey">(6f02874)</span></li>

 <li>libs/kotext/styles/KoListStyle.h <span style="color: grey">(aeb0e47)</span></li>

 <li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: \
grey">(f57958a)</span></li>

 <li>libs/textlayout/KoTextLayoutArea_paint.cpp <span style="color: \
grey">(ec70381)</span></li>

 <li>libs/textlayout/ListItemsHelper.cpp <span style="color: \
grey">(90f82a7)</span></li>

 <li>plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp <span style="color: \
grey">(97ee24a)</span></li>

 <li>plugins/textshape/dialogs/ParagraphIndentSpacing.h <span style="color: \
grey">(3ea8323)</span></li>

 <li>plugins/textshape/dialogs/ParagraphIndentSpacing.cpp <span style="color: \
grey">(bb4c224)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101500/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 