[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Random failures in the test kotext-odf-TestChangeTracking
From:       Ganesh Paramasivam <ganesh () crystalfab ! com>
Date:       2011-05-25 17:22:03
Message-ID: BANLkTinRVRxi7EuUEQhuQxEM-t4VS4-EUQ () mail ! gmail ! com
[Download RAW message or body]

Casper,

I just took a quick look at this and here is the analysis

- A vast majority ( all ? ) of the test failures are due to failures
in saving delete changes.
- According to the original code, deleted fragments are inserted into
the document before a save and removed after a save.
- The code to do the above step was available in the saveOdf()
function of libs/kotext/KoTextShapeData.cpp
- I see that this file has been removed and on examining the git logs,
I see that this file has been moved to libs/textlayout
- Also looks like saveOdf() of KoTextShapeData() is never called (
From the fact that TestChangeTracking does not link to this library)
- So delete changes are not inserted into the document before a save
and hence all the test failures.

So, for change tracking to be restored, the functionality that is
available in saveOdf of KoTextShapeData ( i.e. inserting delete
changes before a save and removing them after a save) should be moved
to the appropriate place in the new design.

Also, if the above analysis is correct, the right people to fix this
issue really fast are the developers working on the textlayout
library. I do not know anything about the new design to be able to fix
this problem in a short time.

Thanks,
Ganesh

On Wed, May 25, 2011 at 9:14 PM, C. Boemann <cbo@boemann.dk> wrote:
> Hi Ganesh
>
> As soon as possible. We have seen a lot of issues with the changetracking to
> the point of us regretting that we have merged it into master. It's too late
> to revert it now, but getting things fixed has a very high priority.
>
> best regards
> Casper
>
> On Wednesday 25 May 2011 17:38:20 Ganesh Paramasivam wrote:
>> Casper,
>>
>> I have been on travel on haven't had a chance to look ( also the
>> situation is going to be same for the next 10 days ). If you could
>> give me a target date by when you would like to see this fixed, I will
>> squeeze some time to fix this.
>>
>> Thanks,
>> Ganesh
>>
>> On Wed, May 25, 2011 at 9:03 PM, C. Boemann <cbo@boemann.dk> wrote:
>> > Hi
>> >
>> > is this still an issue and, Ganesh have you had a chance to look.
>> >
>> > best regards
>> > Casper
>> >
>> > On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote:
>> >> Hi,
>> >>
>> >> Looks like saving of delete changes in broken ( and probably not
>> >> related to the random failures ). Will take a look at it.
>> >> Can this wait till the weekend for a fix ?
>> >>
>> >> Thanks,
>> >> Ganesh
>> >>
>> >> On Mon, May 16, 2011 at 2:04 PM, Cyrille Berger Skott
>> >>
>> >> <cberger@cberger.net> wrote:
>> >> > Hi,
>> >> >
>> >> > I now get "permanent" failure in the unit test:
>> >> > http://my.cdash.org/testDetails.php?test=6063659&build=187759
>> >> >
>> >> > It seems it happened after the merge of the new text layout.
>> >> >
>> >> > --
>> >> > Cyrille Berger Skott
>> >> > _______________________________________________
>> >> > calligra-devel mailing list
>> >> > calligra-devel@kde.org
>> >> > https://mail.kde.org/mailman/listinfo/calligra-devel
>> >>
>> >> _______________________________________________
>> >> calligra-devel mailing list
>> >> calligra-devel@kde.org
>> >> https://mail.kde.org/mailman/listinfo/calligra-devel
>> >
>> > _______________________________________________
>> > calligra-devel mailing list
>> > calligra-devel@kde.org
>> > https://mail.kde.org/mailman/listinfo/calligra-devel
>>
>> _______________________________________________
>> calligra-devel mailing list
>> calligra-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/calligra-devel
> _______________________________________________
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]