[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Add an initial implementation of KoFind to Tables
From: "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date: 2011-05-05 12:51:28
Message-ID: 20110505125128.17337.7645 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101295/#review3128
-----------------------------------------------------------
Ship it!
Looks good in general I guess, one thing would be to match the current sear=
ching code in tables it would need to search in userinput instead of values=
(although I'm not quite sure which would be more expected, displayText() w=
ould probably be even better, but looking up that for every cell is a very =
heavy operation since it requires actual formatting of the value).
And another thing still missing that the current search code has is the opt=
ion to search in notes/comments.
If you add those as TODO's to the code I guess it should be fine to go in s=
ince the code won't be used already anyway.
- Marijn
On May 5, 2011, 12:42 p.m., Arjen Hiemstra wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101295/
> -----------------------------------------------------------
> =
> (Updated May 5, 2011, 12:42 p.m.)
> =
> =
> Review request for Calligra and Marijn Kruisselbrink.
> =
> =
> Summary
> -------
> =
> This patch adds an initial implementation of KoFindBase to Tables that ca=
n search through a Tables sheet. It does not yet do highlighting and other =
features, but the basic functionality works.
> =
> =
> Diffs
> -----
> =
> tables/CMakeLists.txt dad70dc =
> tables/Find.h PRE-CREATION =
> tables/Find.cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/101295/diff
> =
> =
> Testing
> -------
> =
> Added the KoFindToolBar to Tables in the branch and used that to test the=
code.
> =
> =
> Thanks,
> =
> Arjen
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101295/">http://git.reviewboard.kde.org/r/101295/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good in general I \
guess, one thing would be to match the current searching code in tables it would need \
to search in userinput instead of values (although I'm not quite sure which would \
be more expected, displayText() would probably be even better, but looking up that \
for every cell is a very heavy operation since it requires actual formatting of the \
value).
And another thing still missing that the current search code has is the option to \
search in notes/comments.
If you add those as TODO's to the code I guess it should be fine to go in since \
the code won't be used already anyway.</pre> <br />
<p>- Marijn</p>
<br />
<p>On May 5th, 2011, 12:42 p.m., Arjen Hiemstra wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Arjen Hiemstra.</div>
<p style="color: grey;"><i>Updated May 5, 2011, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds an initial implementation of KoFindBase to Tables that \
can search through a Tables sheet. It does not yet do highlighting and other \
features, but the basic functionality works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added the KoFindToolBar to Tables in the branch and used that to test \
the code.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tables/CMakeLists.txt <span style="color: grey">(dad70dc)</span></li>
<li>tables/Find.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tables/Find.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101295/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic