[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Stage: save zoom factor for normal view and slides
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2011-04-15 3:03:29
Message-ID: 20110415030329.29555.40662 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101129/#review2654
-----------------------------------------------------------
Please don't remove the feature of having space around the slide just to ma=
ke the new feature work. Try to fix the problem instead of removing the fea=
ture.
How about centreing the canvas after loading?
It is not a good idea to store view settings in the document as there can b=
e more the one view. How about save the settings per view. Maybe only save =
it for the first view but the saving should be done inside the view and not=
inside the document as when opening only one view is visible. That would a=
lso avoid having this extra signal that was added.
kpresenter/part/KPrDocument.cpp
<http://git.reviewboard.kde.org/r/101129/#comment2361>
Please remove the blanks after ( and before )
kpresenter/part/KPrView.cpp
<http://git.reviewboard.kde.org/r/101129/#comment2359>
there should be no blank before the opening (
kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/101129/#comment2358>
Is it needed to update the model just when changing the active page?
libs/kopageapp/KoPAView.cpp
<http://git.reviewboard.kde.org/r/101129/#comment2357>
Sorry, but that has to be kept. I really like the feature and it is som=
ething that is supported by ODF to have stuff outside of the page.
- Thorsten
On April 14, 2011, 10:53 p.m., Paul Mendez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101129/
> -----------------------------------------------------------
> =
> (Updated April 14, 2011, 10:53 p.m.)
> =
> =
> Review request for Calligra.
> =
> =
> Summary
> -------
> =
> Add save of zoom factor and mode for normal view and slides sorter. Also =
eliminate page and width options of zooming in Slides Sorter (these options=
doesn't make much sense in that view).
> Finally I eliminate the white space around the slide because it make the =
slide lost focus when zooming and when I restore the previous zoom value (t=
he zoom function center the white space too), in addition the white space m=
ake too big the default size of shapes when inserted.
> (I ask in calligra channel, and the white space was added to have an area=
for insert things, maybe it could be added in a better way).
> =
> =
> Diffs
> -----
> =
> kpresenter/part/KPrDocument.h 30bfae0ccee8e4a3775b9629358102bbe85cd6ad =
> kpresenter/part/KPrDocument.cpp 1d94bb97cbfe0b6922290aa00f38191616feaff=
4 =
> kpresenter/part/KPrView.h 80b67520be60500ecf11df0827f1d4ee8eeab4e7 =
> kpresenter/part/KPrView.cpp aef56d9fcb919a314f0095629bea1927916f8059 =
> kpresenter/part/KPrViewModeSlidesSorter.h ec5f6691072115eb7818f1eb224f6=
a03fe9bf13c =
> kpresenter/part/KPrViewModeSlidesSorter.cpp b4fee3c755aebf65e9bff0cef55=
16776533ec4a6 =
> libs/kopageapp/KoPAView.cpp c53edecb309098949f66e9d50238bc60f26f9bee =
> =
> Diff: http://git.reviewboard.kde.org/r/101129/diff
> =
> =
> Testing
> -------
> =
> build and run
> =
> =
> Thanks,
> =
> Paul
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101129/">http://git.reviewboard.kde.org/r/101129/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please don't remove \
the feature of having space around the slide just to make the new feature work. Try \
to fix the problem instead of removing the feature. How about centreing the canvas \
after loading?
It is not a good idea to store view settings in the document as there can be more the \
one view. How about save the settings per view. Maybe only save it for the first view \
but the saving should be done inside the view and not inside the document as when \
opening only one view is visible. That would also avoid having this extra signal that \
was added.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101129/diff/1/?file=14455#file14455line285" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kpresenter/part/KPrDocument.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KPrDocument::loadKPrConfig()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">285</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span> <span class="n">config</span><span \
class="o">-></span><span class="n">hasGroup</span><span class="p">(</span> <span \
class="s">"Interface"</span> <span class="p">)</span> <span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">286</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KConfigGroup</span> <span class="n">interface</span> <span \
class="o">=</span> <span class="n">config</span><span class="o">-></span><span \
class="n">group</span><span class="p">(</span> <span \
class="s">"Interface"</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
remove the blanks after ( and before )</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101129/diff/1/?file=14457#file14457line448" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kpresenter/part/KPrView.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void KPrView::zoomChanged(KoZoomMode::Mode mode, qreal zoom)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">448</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kprDocument</span> <span class="p">()</span><span \
class="o">-></span><span class="n">setZoom</span><span class="p">(</span><span \
class="n">qRound</span><span class="p">(</span><span class="n">zoom</span> <span \
class="o">*</span> <span class="mf">100.0</span><span class="p">));</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">449</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kprDocument</span> <span class="p">()</span><span \
class="o">-></span><span class="n">setZoomMode</span> <span \
class="p">(</span><span class="n">mode</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there \
should be no blank before the opening (</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101129/diff/1/?file=14459#file14459line223" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kpresenter/part/KPrViewModeSlidesSorter.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KPrViewModeSlidesSorter::activate(KoPAViewMode *previousViewMode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">222</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span><span class="n">m_view</span><span \
class="o">-></span><span class="n">proxyObject</span><span class="p">,</span> \
<span class="n">SIGNAL</span><span class="p">(</span><span \
class="n">activePageChanged</span><span class="p">()),</span> <span \
class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">update<span class="hl">PageAdded</span></span><span \
class="p">()));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">223</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_view</span><span class="o">-></span><span \
class="n">proxyObject</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">activePageChanged</span><span class="p">()),</span> <span \
class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">update<span class="hl">Model</span></span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it \
needed to update the model just when changing the active page?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101129/diff/1/?file=14460#file14460line625" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kopageapp/KoPAView.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoPAView::doUpdateActivePage( KoPAPageBase * page )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">625</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">canvas</span><span \
class="o">-></span><span class="n">setDocumentOrigin</span><span \
class="p">(</span><span class="n">QPointF</span><span class="p">(</span><span \
class="n">layout</span><span class="p">.</span><span class="n">width</span><span \
class="p">,</span> <span class="n">layout</span><span class="p">.</span><span \
class="n">height</span><span class="p">));</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">625</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"><span \
class="hl">//</span>d->canvas->setDocumentOrigin(QPointF(layout.width, \
layout.height));</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">626</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// the \
page is in the center of the canvas</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">626</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// the \
page is in the center of the canvas</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">627</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span \
class="n">zoomController</span><span class="o">-></span><span \
class="n">setDocumentSize</span><span class="p">(</span><span \
class="n">pageSize</span><span class="hl"> </span><span class="o"><span \
class="hl">*</span></span><span class="hl"> </span><span class="mi"><span \
class="hl">3</span></span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">627</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span \
class="n">zoomController</span><span class="o">-></span><span \
class="n">setDocumentSize</span><span class="p">(</span><span \
class="n">pageSize</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, but \
that has to be kept. I really like the feature and it is something that is supported \
by ODF to have stuff outside of the page.</pre> </div>
<br />
<p>- Thorsten</p>
<br />
<p>On April 14th, 2011, 10:53 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated April 14, 2011, 10:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add save of zoom factor and mode for normal view and slides sorter. Also \
eliminate page and width options of zooming in Slides Sorter (these options \
doesn't make much sense in that view). Finally I eliminate the white space around \
the slide because it make the slide lost focus when zooming and when I restore the \
previous zoom value (the zoom function center the white space too), in addition the \
white space make too big the default size of shapes when inserted. (I ask in calligra \
channel, and the white space was added to have an area for insert things, maybe it \
could be added in a better way).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build and run</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpresenter/part/KPrDocument.h <span style="color: \
grey">(30bfae0ccee8e4a3775b9629358102bbe85cd6ad)</span></li>
<li>kpresenter/part/KPrDocument.cpp <span style="color: \
grey">(1d94bb97cbfe0b6922290aa00f38191616feaff4)</span></li>
<li>kpresenter/part/KPrView.h <span style="color: \
grey">(80b67520be60500ecf11df0827f1d4ee8eeab4e7)</span></li>
<li>kpresenter/part/KPrView.cpp <span style="color: \
grey">(aef56d9fcb919a314f0095629bea1927916f8059)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.h <span style="color: \
grey">(ec5f6691072115eb7818f1eb224f6a03fe9bf13c)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.cpp <span style="color: \
grey">(b4fee3c755aebf65e9bff0cef5516776533ec4a6)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: \
grey">(c53edecb309098949f66e9d50238bc60f26f9bee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101129/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic