[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Text saving broken
From:       Pierre <pinaraf () pinaraf ! info>
Date:       2011-04-14 23:14:09
Message-ID: 201104150114.16763.pinaraf () pinaraf ! info
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 14 April 2011 10:20:23 Thorsten Zachmann wrote:
> Hello,
> 
> when I wanted to test some stuff I found out that saving of text is
> currently broken.
> 
> At the moment we save text like that:
> 
>         <draw:frame draw:style-name="gr2" draw:id="shape3" draw:layer=""
> svg:width="300.00000000000pt" svg:height="200.00000000000pt"
> svg:x="108.74767855096pt" svg:y="113.47540983607pt">
>           <draw:text-box text:style-name="P3" text:id="subitem1">This is a
> text</draw:text-box>
>         </draw:frame>
> 
> This is wrong as it should look like
> 
>         <draw:frame draw:style-name="gr2" draw:id="shape3" draw:layer=""
> svg:width="391.41463414634pt" svg:height="239.36675700090pt"
> svg:x="102.82926829268pt" svg:y="226.19060523939pt">
>           <draw:text-box>
>             <text:p text:style-name="P3" text:id="subitem1">This is a
> text</text:p>
>           </draw:text-box>
>         </draw:frame>
> 
> We now miss the <text:p> tag.
> 
> The change causing that is at least after commit
> 0e18ccbabb634a4769434452a960870549373691
> 
> which still works without problems.
> 
> Would  be nice if someone who had been working on text saving could have a
> look at that.
Fixed, was an unhappy consequence of the change tracking work.

@Ganesh : I don't know the change tracking specification, but I really don't 
like the way the code had to be modified to support it. Is there no way to have 
it in a less mixed-in way ? I mean, right now, you can't tell between the 
classical text related calls and the calls for change tracking. It was already 
messy and dirty enough... Moreover, do unit tests only cover the case where 
change tracking is enabled ? In any case, there is a real issue since the 
regressions I fixed here are major and should have been spotted far sooner... 
(I'll try to find some ways to improve our unit testing in that area anyway).
But, for instance, you often check a save format, between deltaxml and odf 1.2 : 
what are the differences ? Why are both needed ?
If you don't mind, a short explanation email would be helpful (or an IRC session 
if you prefer...)

 Pierre

["signature.asc" (application/pgp-signature)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread]