'Re: Review Request: Refactor of KoFind to a general interface for'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Refactor of KoFind to a general interface for
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2011-04-09 12:43:42
Message-ID: 20110409124342.14346.21500 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101045/#review2516
-----------------------------------------------------------

Ship it!

Provided you fix the minor issues then please merge asap

- Casper

On April 7, 2011, 12:11 p.m., Arjen Hiemstra wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101045/
> -----------------------------------------------------------
> =

> (Updated April 7, 2011, 12:11 p.m.)
> =

> =

> Review request for Calligra, Marijn Kruisselbrink, Boudewijn Rempt, Thors=
ten Zachmann, and Casper Boemann.
> =

> =

> Summary
> -------
> =

> This is the diff of the branch libs-kofind_refactor-ahiemstra and master.=
 It encompasses the entire refactor of KoFind to a more generic structure t=
hat can be used by different interfaces and by different document types.
> =

> I consider this to be done API-wise, though several features are currentl=
y missing. This review therefore is mostly a request for comments about the=
 current API.
> =

> Still to be done feature-wise:
> - Add support for more options (search in selection, search from cursor, =
regex, etc)
> - Properly implement replacing, including implementing an interface for i=
t.
> - Add support for searching through multiple text shapes to KoFindText.
> - Implement a searching backend for tables.
> =

> =

> Diffs
> -----
> =

>   libs/kotext/KoTextDocument.h 6d755f8 =

>   libs/kotext/KoTextDocument.cpp 1517953 =

>   libs/main/CMakeLists.txt a7f3077 =

>   libs/main/KoFindBase.h PRE-CREATION =

>   libs/main/KoFindBase.cpp PRE-CREATION =

>   libs/main/KoFindMatch.h PRE-CREATION =

>   libs/main/KoFindMatch.cpp PRE-CREATION =

>   libs/main/KoFindOption.h PRE-CREATION =

>   libs/main/KoFindOption.cpp PRE-CREATION =

>   libs/main/KoFindOptionSet.h PRE-CREATION =

>   libs/main/KoFindOptionSet.cpp PRE-CREATION =

>   libs/main/KoFindText.h PRE-CREATION =

>   libs/main/KoFindText.cpp PRE-CREATION =

>   libs/main/KoFindToolbar.h PRE-CREATION =

>   libs/main/KoFindToolbar.cpp PRE-CREATION =

>   libs/main/tests/CMakeLists.txt 6f13036 =

>   libs/main/tests/testfindmatch.h PRE-CREATION =

>   libs/main/tests/testfindmatch.cpp PRE-CREATION =

>   plugins/textshape/TextShape.cpp 1c8f2c5 =

>   words/part/KWView.h a8eec16 =

>   words/part/KWView.cpp 539e6b1 =

> =

> Diff: http://git.reviewboard.kde.org/r/101045/diff
> =

> =

> Testing
> -------
> =

> I have implemented a toolbar interface for Words, which is enabled in thi=
s review. It works very well, though it does not yet feature all the option=
s the current dialog has. Furthermore, I have implemented unit tests for Ko=
FindMatch, the most important class in this code, though arguably at least =
KoFindOption/KoFindOptionSet also could do with some unit testing.
> =

> =

> Thanks,
> =

> Arjen
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101045/">http://git.reviewboard.kde.org/r/101045/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provided you fix the \
minor issues then please merge asap</pre>  <br />

<p>- Casper</p>

<br />
<p>On April 7th, 2011, 12:11 p.m., Arjen Hiemstra wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra, Marijn Kruisselbrink, Boudewijn Rempt, Thorsten \
Zachmann, and Casper Boemann.</div> <div>By Arjen Hiemstra.</div>

<p style="color: grey;"><i>Updated April 7, 2011, 12:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the diff of the branch libs-kofind_refactor-ahiemstra and \
master. It encompasses the entire refactor of KoFind to a more generic structure that \
can be used by different interfaces and by different document types.

I consider this to be done API-wise, though several features are currently missing. \
This review therefore is mostly a request for comments about the current API.

Still to be done feature-wise:
- Add support for more options (search in selection, search from cursor, regex, etc)
- Properly implement replacing, including implementing an interface for it.
- Add support for searching through multiple text shapes to KoFindText.
- Implement a searching backend for tables.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have implemented a toolbar interface for Words, which is enabled in \
this review. It works very well, though it does not yet feature all the options the \
current dialog has. Furthermore, I have implemented unit tests for KoFindMatch, the \
most important class in this code, though arguably at least \
KoFindOption/KoFindOptionSet also could do with some unit testing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/kotext/KoTextDocument.h <span style="color: grey">(6d755f8)</span></li>

 <li>libs/kotext/KoTextDocument.cpp <span style="color: grey">(1517953)</span></li>

 <li>libs/main/CMakeLists.txt <span style="color: grey">(a7f3077)</span></li>

 <li>libs/main/KoFindBase.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindMatch.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindMatch.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindOption.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindOption.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindOptionSet.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindOptionSet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindText.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindText.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindToolbar.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/KoFindToolbar.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/main/tests/CMakeLists.txt <span style="color: grey">(6f13036)</span></li>

 <li>libs/main/tests/testfindmatch.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/main/tests/testfindmatch.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/textshape/TextShape.cpp <span style="color: grey">(1c8f2c5)</span></li>

 <li>words/part/KWView.h <span style="color: grey">(a8eec16)</span></li>

 <li>words/part/KWView.cpp <span style="color: grey">(539e6b1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101045/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 