[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Limit zooming to a minimum and maximum zoom value
From: "Arjen Hiemstra" <djfreestyler () gmail ! com>
Date: 2011-02-09 11:14:26
Message-ID: 20110209111426.22839.27376 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 9, 2011, 9:25 a.m., Marijn Kruisselbrink wrote:
> > libs/widgets/KoZoomMode.cpp, lines 32-33
> > <http://git.reviewboard.kde.org/r/100613/diff/1/?file=8798#file8798line32>
> >
> > Maybe keep the default values to those that are currently used by KoZoomAction? \
> > thus 0.0625 - 16
The reason I didn't do that is because this does not solve the bug in Tables. A \
minimum zoom of 0.0625 still completely kills it, while a maximum zoom of 16 will \
still allow you to get lost. These values are closer to what the dropdown supplies \
instead.
- Arjen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/#review1319
-----------------------------------------------------------
On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100613/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2011, 12:45 a.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> This bug fixes an issue with Calligra's zoom handling, caused by not limiting the \
> minimum and maximum zoom levels. Currently it is possible to completely freeze \
> Tables (or cause even more serious issues) by zoom out far enough. Zooming in on \
> the other hand can cause you to get completely lost in your document.
> Note that for Krita and others, the default minimum and maximum zoom might not be \
> the best choice, which is why I included a setter for the minimum and maximum \
> values.
>
> Diffs
> -----
>
> libs/widgets/KoZoomAction.cpp 4ef4d8b
> libs/widgets/KoZoomController.cpp 54b9168
> libs/widgets/KoZoomHandler.cpp ce234e6
> libs/widgets/KoZoomMode.h 9bfd195
> libs/widgets/KoZoomMode.cpp 293f1af
>
> Diff: http://git.reviewboard.kde.org/r/100613/diff
>
>
> Testing
> -------
>
> Tested on Words, Stage, Tables and Krita. This patch currently breaks the zoom \
> handler unit test, which I will fix after this.
>
> Thanks,
>
> Arjen
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100613/">http://git.reviewboard.kde.org/r/100613/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 9th, 2011, 9:25 a.m., <b>Marijn \
Kruisselbrink</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100613/diff/1/?file=8798#file8798line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/widgets/KoZoomMode.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const \
char* KoZoomMode::modes[] =</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">qreal</span> <span class="n">KoZoomMode</span><span \
class="o">::</span><span class="n">minimumZoomValue</span> <span class="o">=</span> \
<span class="mf">0.2</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">qreal</span> <span class="n">KoZoomMode</span><span \
class="o">::</span><span class="n">maximumZoomValue</span> <span class="o">=</span> \
<span class="mf">5.0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe keep the default \
values to those that are currently used by KoZoomAction? thus 0.0625 - 16</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reason \
I didn't do that is because this does not solve the bug in Tables. A minimum zoom \
of 0.0625 still completely kills it, while a maximum zoom of 16 will still allow you \
to get lost. These values are closer to what the dropdown supplies instead.</pre> <br \
/>
<p>- Arjen</p>
<br />
<p>On February 9th, 2011, 12:45 a.m., Arjen Hiemstra wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Arjen Hiemstra.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2011, 12:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This bug fixes an issue with Calligra's zoom handling, caused by not \
limiting the minimum and maximum zoom levels. Currently it is possible to completely \
freeze Tables (or cause even more serious issues) by zoom out far enough. Zooming in \
on the other hand can cause you to get completely lost in your document.
Note that for Krita and others, the default minimum and maximum zoom might not be the \
best choice, which is why I included a setter for the minimum and maximum \
values.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on Words, Stage, Tables and Krita. This patch currently breaks \
the zoom handler unit test, which I will fix after this.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoZoomAction.cpp <span style="color: grey">(4ef4d8b)</span></li>
<li>libs/widgets/KoZoomController.cpp <span style="color: \
grey">(54b9168)</span></li>
<li>libs/widgets/KoZoomHandler.cpp <span style="color: grey">(ce234e6)</span></li>
<li>libs/widgets/KoZoomMode.h <span style="color: grey">(9bfd195)</span></li>
<li>libs/widgets/KoZoomMode.cpp <span style="color: grey">(293f1af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100613/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic