[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: kplato compile problem on windows
From: Pierre Stirnweiss <pstirnweiss () googlemail ! com>
Date: 2011-01-24 13:18:18
Message-ID: AANLkTi=o6vtPo4WAOtxf9Xc3AMt4Lj=sBoxAG6TsZo-7 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
do we have a consensus on one solution over the other?
PierreSt
On Mon, Jan 24, 2011 at 10:51 AM, Dag Andersen <danders@get2net.dk> wrote:
> Mandag 24 januar 2011 10:37:00 skrev Cyrille Berger Skott:
> > On Monday 24 January 2011, Pierre Stirnweiss wrote:
> > > I can try the nepomuk solution (using KPLATO_EXPORT on each methods of
> > > the class instead of on the class itself) this evening. This would
> > > probably be the minimal impact solution.
> > > Just so I am clear, it seems that in nepomuk they have only specified
> > > NEPOMUK_EXPORT on some of the methods. My assumption is that they
> > > exported only the methods which were really used outside? Otherwise I
> > > don't really understand why isFileDataObject would get the EXPORT and
> > > not isFolder for example.
> >
> > Generally speaking, you only need to export what is really used outside
> :)
> > We usually export the whole class, because if a function is public, we
> > assume that it wants to be used. I don't know what is the intent of
> > "libs/kernel", if it is strictly private to kplato/plan, then exporting
> > only the needed function make sense.
> I put the basics into separate lib because I thought maybe in the
> (distant?)
> future one could use it independently of the current plan/kplato gui.
> >
> > (Personnally, I would go for Jan's solution and hide the QMap, because I
> > don't like to inherits from the containers, but I guess it is a matter of
> > taste :) )
>
> --
> Mvh.
> Dag Andersen
> _______________________________________________
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>
[Attachment #5 (text/html)]
do we have a consensus on one solution over the other?<br><br>PierreSt<br><br><div \
class="gmail_quote">On Mon, Jan 24, 2011 at 10:51 AM, Dag Andersen <span \
dir="ltr"><<a href="mailto:danders@get2net.dk">danders@get2net.dk</a>></span> \
wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Mandag 24 januar 2011 \
10:37:00 skrev Cyrille Berger Skott:<br> <div class="im">> On Monday 24 January \
2011, Pierre Stirnweiss wrote:<br> > > I can try the nepomuk solution (using \
KPLATO_EXPORT on each methods of<br> > > the class instead of on the class \
itself) this evening. This would<br> > > probably be the minimal impact \
solution.<br> > > Just so I am clear, it seems that in nepomuk they have only \
specified<br> > > NEPOMUK_EXPORT on some of the methods. My assumption is that \
they<br> > > exported only the methods which were really used outside? \
Otherwise I<br> > > don't really understand why isFileDataObject would get \
the EXPORT and<br> > > not isFolder for example.<br>
><br>
> Generally speaking, you only need to export what is really used outside :)<br>
> We usually export the whole class, because if a function is public, we<br>
> assume that it wants to be used. I don't know what is the intent of<br>
> "libs/kernel", if it is strictly private to kplato/plan, then \
exporting<br> > only the needed function make sense.<br>
</div>I put the basics into separate lib because I thought maybe in the \
(distant?)<br> future one could use it independently of the current plan/kplato \
gui.<br> <div class="im">><br>
> (Personnally, I would go for Jan's solution and hide the QMap, because I<br>
> don't like to inherits from the containers, but I guess it is a matter \
of<br> > taste :) )<br>
<br>
--<br>
</div>Mvh.<br>
<font color="#888888">Dag Andersen<br>
</font><div><div></div><div \
class="h5">_______________________________________________<br> calligra-devel mailing \
list<br> <a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br> \
</div></div></blockquote></div><br>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic