[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calendarserver-changes
Subject:    [CalendarServer-changes] [13064] CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py
From:       source_changes () macosforge ! org
Date:       2014-03-31 21:23:55
Message-ID: 20140331212355.6BE43140E2F () svn ! calendarserver ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Revision: 13064
          http://trac.calendarserver.org//changeset/13064
Author:   wsanchez@apple.com
Date:     2014-03-31 14:23:55 -0700 (Mon, 31 Mar 2014)
Log Message:
-----------
lint

Modified Paths:
--------------
    CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py

Modified: CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py
===================================================================
--- CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py	2014-03-31 20:41:45 UTC (rev 13063)
+++ CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py	2014-03-31 21:23:55 UTC (rev 13064)
@@ -218,7 +218,8 @@
 @inlineCallbacks
 def getWikiACL(resource, request):
     """
-    Ask the wiki server we're paired with what level of access the authnUser has.
+    Ask the wiki server we're paired with what level of access the authnUser
+    has.
 
     Returns an ACL.
 
@@ -265,15 +266,17 @@
                         davxml.Privilege(davxml.Read()),
                         davxml.Privilege(davxml.ReadCurrentUserPrivilegeSet()),
 
-                        # We allow write-properties so that direct sharees can change
-                        # e.g. calendar color properties
+                        # We allow write-properties so that direct sharees can
+                        # change e.g. calendar color properties
                         davxml.Privilege(davxml.WriteProperties()),
                     ),
                     TwistedACLInheritable(),
                 ),
                 davxml.ACE(
                     davxml.Principal(
-                        davxml.HRef.fromString("/principals/wikis/%s/" % (wikiID,))
+                        davxml.HRef.fromString(
+                            "/principals/wikis/{}/".format(wikiID)
+                        )
                     ),
                     davxml.Grant(
                         davxml.Privilege(davxml.Read()),
@@ -297,7 +300,9 @@
                 ),
                 davxml.ACE(
                     davxml.Principal(
-                        davxml.HRef.fromString("/principals/wikis/%s/" % (wikiID,))
+                        davxml.HRef.fromString(
+                            "/principals/wikis/{}/".format(wikiID)
+                        )
                     ),
                     davxml.Grant(
                         davxml.Privilege(davxml.Read()),
@@ -330,6 +335,8 @@
         # pass through the HTTPError we might have raised above
         raise
 
-    except Exception, e:
-        log.error("Wiki ACL lookup failed: %s" % (e,))
-        raise HTTPError(StatusResponse(responsecode.SERVICE_UNAVAILABLE, "Wiki ACL lookup failed"))
+    except Exception as e:
+        log.error("Wiki ACL lookup failed: {error}", error=e)
+        raise HTTPError(StatusResponse(
+            responsecode.SERVICE_UNAVAILABLE, "Wiki ACL lookup failed"
+        ))

[Attachment #5 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13064] CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py</title>
 </head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.calendarserver.org//changeset/13064">13064</a></dd> <dt>Author</dt> \
<dd>wsanchez@apple.com</dd> <dt>Date</dt> <dd>2014-03-31 14:23:55 -0700 (Mon, 31 Mar \
2014)</dd> </dl>

<h3>Log Message</h3>
<pre>lint</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServerbranchesuserssagenmove2who4txdavwhowikipy">CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServerbranchesuserssagenmove2who4txdavwhowikipy"></a>
<div class="modfile"><h4>Modified: \
CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py (13063 => \
13064)</h4> <pre class="diff"><span>
<span class="info">--- \
CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py	2014-03-31 20:41:45 \
                UTC (rev 13063)
+++ CalendarServer/branches/users/sagen/move2who-4/txdav/who/wiki.py	2014-03-31 \
21:23:55 UTC (rev 13064) </span><span class="lines">@@ -218,7 +218,8 @@
</span><span class="cx"> @inlineCallbacks
</span><span class="cx"> def getWikiACL(resource, request):
</span><span class="cx">     &quot;&quot;&quot;
</span><del>-    Ask the wiki server we're paired with what level of access the \
authnUser has. </del><ins>+    Ask the wiki server we're paired with what level of \
access the authnUser +    has.
</ins><span class="cx"> 
</span><span class="cx">     Returns an ACL.
</span><span class="cx"> 
</span><span class="lines">@@ -265,15 +266,17 @@
</span><span class="cx">                         davxml.Privilege(davxml.Read()),
</span><span class="cx">                         \
davxml.Privilege(davxml.ReadCurrentUserPrivilegeSet()), </span><span class="cx"> 
</span><del>-                        # We allow write-properties so that direct \
                sharees can change
-                        # e.g. calendar color properties
</del><ins>+                        # We allow write-properties so that direct \
sharees can +                        # change e.g. calendar color properties
</ins><span class="cx">                         \
davxml.Privilege(davxml.WriteProperties()), </span><span class="cx">                  \
), </span><span class="cx">                     TwistedACLInheritable(),
</span><span class="cx">                 ),
</span><span class="cx">                 davxml.ACE(
</span><span class="cx">                     davxml.Principal(
</span><del>-                        \
davxml.HRef.fromString(&quot;/principals/wikis/%s/&quot; % (wikiID,)) </del><ins>+    \
davxml.HRef.fromString( +                            \
&quot;/principals/wikis/{}/&quot;.format(wikiID) +                        )
</ins><span class="cx">                     ),
</span><span class="cx">                     davxml.Grant(
</span><span class="cx">                         davxml.Privilege(davxml.Read()),
</span><span class="lines">@@ -297,7 +300,9 @@
</span><span class="cx">                 ),
</span><span class="cx">                 davxml.ACE(
</span><span class="cx">                     davxml.Principal(
</span><del>-                        \
davxml.HRef.fromString(&quot;/principals/wikis/%s/&quot; % (wikiID,)) </del><ins>+    \
davxml.HRef.fromString( +                            \
&quot;/principals/wikis/{}/&quot;.format(wikiID) +                        )
</ins><span class="cx">                     ),
</span><span class="cx">                     davxml.Grant(
</span><span class="cx">                         davxml.Privilege(davxml.Read()),
</span><span class="lines">@@ -330,6 +335,8 @@
</span><span class="cx">         # pass through the HTTPError we might have raised \
above </span><span class="cx">         raise
</span><span class="cx"> 
</span><del>-    except Exception, e:
-        log.error(&quot;Wiki ACL lookup failed: %s&quot; % (e,))
-        raise HTTPError(StatusResponse(responsecode.SERVICE_UNAVAILABLE, &quot;Wiki \
ACL lookup failed&quot;)) </del><ins>+    except Exception as e:
+        log.error(&quot;Wiki ACL lookup failed: {error}&quot;, error=e)
+        raise HTTPError(StatusResponse(
+            responsecode.SERVICE_UNAVAILABLE, &quot;Wiki ACL lookup failed&quot;
+        ))
</ins></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
calendarserver-changes mailing list
calendarserver-changes@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/calendarserver-changes


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic