[prev in list] [next in list] [prev in thread] [next in thread]
List: calendarserver-changes
Subject: [CalendarServer-changes] [8779] CalendarServer/branches/users/glyph/case-insensitive-uid
From: source_changes () macosforge ! org
Date: 2012-02-29 18:15:13
Message-ID: 20120229181513.DC60257C8339 () lists ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Revision: 8779
http://trac.macosforge.org/projects/calendarserver/changeset/8779
Author: glyph@apple.com
Date: 2012-02-29 10:15:13 -0800 (Wed, 29 Feb 2012)
Log Message:
-----------
move responsibility for quoting decision into QueryGenerator
Modified Paths:
--------------
CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py
Property Changed:
----------------
CalendarServer/branches/users/glyph/case-insensitive-uid/
Modified: CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py
===================================================================
--- CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py 2012-02-29 \
18:15:10 UTC (rev 8778)
+++ CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py 2012-02-29 \
18:15:13 UTC (rev 8779) @@ -113,7 +113,11 @@
return "genid_%d" % (self.generatedID(),)
+ def shouldQuote(self, name):
+ return (self.dialect == ORACLE_DIALECT and name.lower() in _KEYWORDS)
+
+
class TableMismatch(Exception):
"""
A table in a statement did not match with a column.
@@ -699,7 +703,7 @@
# XXX This, and 'model', could in principle conflict with column names.
# Maybe do something about that.
name = self.model.name
- if queryGenerator.dialect == ORACLE_DIALECT and name.lower() in _KEYWORDS:
+ if queryGenerator.shouldQuote(name):
name = '"%s"' % (name,)
if self._alwaysQualified:
[Attachment #5 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8779] CalendarServer/branches/users/glyph/case-insensitive-uid</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.macosforge.org/projects/calendarserver/changeset/8779">8779</a></dd>
<dt>Author</dt> <dd>glyph@apple.com</dd>
<dt>Date</dt> <dd>2012-02-29 10:15:13 -0800 (Wed, 29 Feb 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>move responsibility for quoting decision into QueryGenerator</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServerbranchesusersglyphcaseinsensitiveuidtwextenterprisedalsynt \
axpy">CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#CalendarServerbranchesusersglyphcaseinsensitiveuid">CalendarServer/branches/users/glyph/case-insensitive-uid/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServerbranchesusersglyphcaseinsensitiveuidtwextenterprisedalsyntaxpy"></a>
<div class="modfile"><h4>Modified: \
CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py \
(8778 => 8779)</h4> <pre class="diff"><span>
<span class="info">--- \
CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py 2012-02-29 \
18:15:10 UTC (rev 8778)
+++ CalendarServer/branches/users/glyph/case-insensitive-uid/twext/enterprise/dal/syntax.py 2012-02-29 \
18:15:13 UTC (rev 8779) </span><span class="lines">@@ -113,7 +113,11 @@
</span><span class="cx"> return "genid_%d" % (self.generatedID(),)
</span><span class="cx">
</span><span class="cx">
</span><ins>+ def shouldQuote(self, name):
+ return (self.dialect == ORACLE_DIALECT and name.lower() in _KEYWORDS)
</ins><span class="cx">
</span><ins>+
+
</ins><span class="cx"> class TableMismatch(Exception):
</span><span class="cx"> """
</span><span class="cx"> A table in a statement did not match with a column.
</span><span class="lines">@@ -699,7 +703,7 @@
</span><span class="cx"> # XXX This, and 'model', could in principle conflict \
with column names. </span><span class="cx"> # Maybe do something about that.
</span><span class="cx"> name = self.model.name
</span><del>- if queryGenerator.dialect == ORACLE_DIALECT and name.lower() in \
_KEYWORDS: </del><ins>+ if queryGenerator.shouldQuote(name):
</ins><span class="cx"> name = '"%s"' % (name,)
</span><span class="cx">
</span><span class="cx"> if self._alwaysQualified:
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
calendarserver-changes mailing list
calendarserver-changes@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic