[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calendarserver-changes
Subject:    [CalendarServer-changes] [4303]
From:       source_changes () macosforge ! org
Date:       2009-05-20 3:52:53
Message-ID: 20090520035253.5BB421B39E46 () beta ! macosforge ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Revision: 4303
          http://trac.macosforge.org/projects/calendarserver/changeset/4303
Author:   cdaboo@apple.com
Date:     2009-05-19 20:52:53 -0700 (Tue, 19 May 2009)
Log Message:
-----------
Add some extra logging for failed instance expansion when indexing.

Modified Paths:
--------------
    CalendarServer/trunk/twistedcaldav/index.py

Modified: CalendarServer/trunk/twistedcaldav/index.py
===================================================================
--- CalendarServer/trunk/twistedcaldav/index.py	2009-05-20 00:41:58 UTC (rev 4302)
+++ CalendarServer/trunk/twistedcaldav/index.py	2009-05-20 03:52:53 UTC (rev 4303)
@@ -49,6 +49,7 @@
 from twistedcaldav.sql import AbstractSQLDatabase
 from twistedcaldav.sql import db_prefix
 from twistedcaldav import caldavxml
+from twistedcaldav.instance import InvalidOverriddenInstanceError
 from twistedcaldav.log import Logger, LoggingMixIn
 from twistedcaldav.config import config
 from twistedcaldav.memcachepool import CachePoolUserMixIn
@@ -486,7 +487,11 @@
             if expand > (datetime.date.today() + maximum_future_expansion_duration):
                 raise IndexedSearchException
 
-        instances = calendar.expandTimeRanges(expand)
+        try:
+            instances = calendar.expandTimeRanges(expand)
+        except InvalidOverriddenInstanceError, e:
+            log.err("Invalid instance %s when indexing %s in %s" % (e.rid, name, self.resource,))
+            raise
 
         self._delete_from_db(name, uid)
 

[Attachment #5 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[4303] CalendarServer/trunk/twistedcaldav/index.py</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.macosforge.org/projects/calendarserver/changeset/4303">4303</a></dd>
 <dt>Author</dt> <dd>cdaboo@apple.com</dd>
<dt>Date</dt> <dd>2009-05-19 20:52:53 -0700 (Tue, 19 May 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add some extra logging for failed instance expansion when indexing.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunktwistedcaldavindexpy">CalendarServer/trunk/twistedcaldav/index.py</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunktwistedcaldavindexpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/index.py (4302 \
=> 4303)</h4> <pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/index.py	2009-05-20 \
                00:41:58 UTC (rev 4302)
+++ CalendarServer/trunk/twistedcaldav/index.py	2009-05-20 03:52:53 UTC (rev 4303)
</span><span class="lines">@@ -49,6 +49,7 @@
</span><span class="cx"> from twistedcaldav.sql import AbstractSQLDatabase
</span><span class="cx"> from twistedcaldav.sql import db_prefix
</span><span class="cx"> from twistedcaldav import caldavxml
</span><ins>+from twistedcaldav.instance import InvalidOverriddenInstanceError
</ins><span class="cx"> from twistedcaldav.log import Logger, LoggingMixIn
</span><span class="cx"> from twistedcaldav.config import config
</span><span class="cx"> from twistedcaldav.memcachepool import CachePoolUserMixIn
</span><span class="lines">@@ -486,7 +487,11 @@
</span><span class="cx">             if expand &gt; (datetime.date.today() + \
maximum_future_expansion_duration): </span><span class="cx">                 raise \
IndexedSearchException </span><span class="cx"> 
</span><del>-        instances = calendar.expandTimeRanges(expand)
</del><ins>+        try:
+            instances = calendar.expandTimeRanges(expand)
+        except InvalidOverriddenInstanceError, e:
+            log.err(&quot;Invalid instance %s when indexing %s in %s&quot; % (e.rid, \
name, self.resource,)) +            raise
</ins><span class="cx"> 
</span><span class="cx">         self._delete_from_db(name, uid)
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
calendarserver-changes mailing list
calendarserver-changes@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-changes


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic