[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo-bugs
Subject:    [cairo-bugs] [Bug 89533] New: pdftocairo -svg produced garbaged shadows in the ouput file
From:       bugzilla-daemon () freedesktop ! org
Date:       2015-03-11 12:40:33
Message-ID: bug-89533-4039 () http ! bugs ! freedesktop ! org/
[Download RAW message or body]

--1426077634.3ffd11.29647
Date: Wed, 11 Mar 2015 12:40:34 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"

https://bugs.freedesktop.org/show_bug.cgi?id=89533

            Bug ID: 89533
           Summary: pdftocairo -svg produced garbaged shadows in the ouput
                    file
           Product: cairo
           Version: 1.12.4
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: quartz backend
          Assignee: vladimir@pobox.com
          Reporter: rapatsky@gmail.com
        QA Contact: cairo-bugs@cairographics.org

Created attachment 114219
  --> https://bugs.freedesktop.org/attachment.cgi?id=114219&action=edit
File with shadows, which garbaged during PDF->SVG conversion

When converting attached file to SVG, I see that square and star objects
shadows are missing. I've used pdftocairo version 0.24.6. Command:
pdftocairo -svg testlinks.pdf

Using git bisect I've found that first commit where shadow rendering was broken
is

commit 8020e0bc8cbd3e5ac188eb305b74ae1c1f362a31
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Oct 3 17:01:41 2012 +0100

In that commit file src/cairo-recording-surface.c was changed.

If I revert this part of diff patch, then shadows rendering brings back.

@@ -1131,7 +1441,7 @@ _cairo_recording_surface_snapshot (void *abstract_other)
     surface->optimize_clears = TRUE;

     _cairo_array_init (&surface->commands, sizeof (cairo_command_t *));
-    status = _cairo_recording_surface_replay (&other->base, &surface->base);
+    status = _cairo_recording_surface_copy (other, surface);
     if (unlikely (status)) {
        cairo_surface_destroy (&surface->base);
        return _cairo_surface_create_in_error (status);

Could you please help me to fix _cairo_recording_surface_copy function to
support shadows?

In the latest cairo builds shadows are broken even more. They are not absent,
but rendered as gray rectangles under the objects.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

--1426077634.3ffd11.29647
Date: Wed, 11 Mar 2015 12:40:34 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"

<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - pdftocairo -svg produced garbaged shadows in the ouput file"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=89533">89533</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>pdftocairo -svg produced garbaged shadows in the ouput file
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>cairo
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>1.12.4
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>quartz backend
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>vladimir&#64;pobox.com
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>rapatsky&#64;gmail.com
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>cairo-bugs&#64;cairographics.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=114219" \
name="attach_114219" title="File with shadows, which garbaged during PDF-&gt;SVG \
conversion">attachment 114219</a> <a href="attachment.cgi?id=114219&amp;action=edit" \
title="File with shadows, which garbaged during PDF-&gt;SVG \
conversion">[details]</a></span> File with shadows, which garbaged during PDF-&gt;SVG \
conversion

When converting attached file to SVG, I see that square and star objects
shadows are missing. I've used pdftocairo version 0.24.6. Command:
pdftocairo -svg testlinks.pdf

Using git bisect I've found that first commit where shadow rendering was broken
is

commit 8020e0bc8cbd3e5ac188eb305b74ae1c1f362a31
Author: Chris Wilson &lt;<a \
                href="mailto:chris&#64;chris-wilson.co.uk">chris&#64;chris-wilson.co.uk</a>&gt;
                
Date:   Wed Oct 3 17:01:41 2012 +0100

In that commit file src/cairo-recording-surface.c was changed.

If I revert this part of diff patch, then shadows rendering brings back.

&#64;&#64; -1131,7 +1441,7 &#64;&#64; _cairo_recording_surface_snapshot (void \
*abstract_other)  surface-&gt;optimize_clears = TRUE;

     _cairo_array_init (&amp;surface-&gt;commands, sizeof (cairo_command_t *));
-    status = _cairo_recording_surface_replay (&amp;other-&gt;base, \
&amp;surface-&gt;base); +    status = _cairo_recording_surface_copy (other, surface);
     if (unlikely (status)) {
        cairo_surface_destroy (&amp;surface-&gt;base);
        return _cairo_surface_create_in_error (status);

Could you please help me to fix _cairo_recording_surface_copy function to
support shadows?

In the latest cairo builds shadows are broken even more. They are not absent,
but rendered as gray rectangles under the objects.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
      </ul>
    </body>
</html>

--1426077634.3ffd11.29647--


[Attachment #3 (text/plain)]

_______________________________________________
cairo-bugs mailing list
cairo-bugs@lists.cairographics.org
http://lists.cairographics.org/mailman/listinfo/cairo-bugs


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic