[prev in list] [next in list] [prev in thread] [next in thread]
List: cairo-bugs
Subject: [cairo-bugs] [Bug 16129] New: Don't export private symbols on
From: bugzilla-daemon () freedesktop ! org
Date: 2008-05-28 9:23:46
Message-ID: bug-16129-4039 () http ! bugs ! freedesktop ! org/
[Download RAW message or body]
http://bugs.freedesktop.org/show_bug.cgi?id=16129
Summary: Don't export private symbols on non-win32 systems
Product: cairo
Version: 1.6.4
Platform: All
OS/Version: All
Status: RESOLVED
Severity: normal
Priority: medium
Component: general
AssignedTo: cworth@cworth.org
ReportedBy: slomo@circular-chaos.org
QAContact: cairo-bugs@cairographics.org
Sebastian Dröge <slomo@circular-chaos.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #16782|0 |1
is obsolete| |
Chris Wilson <chris@chris-wilson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Created an attachment (id=16782)
--> (http://bugs.freedesktop.org/attachment.cgi?id=16782)
cairo-export-symbols.patch
Hi,
it would be nice if cairo didn't export private symbols like
_cairo_atomic_mutex, _cairo_font_face_mutex, etc.
Attached patch makes cairo export whatever is in cairo.def (for some reason I
don't have that file) on win32 as it was before but uses a symbol export regexp
on other systems that makes it export only "^cairo.*" symbols.
Please consider applying this for 1.6.
Thanks
--- Comment #1 from Sebastian Dröge <slomo@circular-chaos.org> 2008-05-28 02:01:53 PST ---
For x86 these symbols are:
$ objdump -T /usr/lib/libcairo.so.2 | grep _cairo
00060bec g DO .bss 00000018 Base _cairo_scaled_font_error_mutex
00060bd4 g DO .bss 00000018 Base _cairo_scaled_font_map_mutex
00060c1c g DO .bss 00000018 Base _cairo_xlib_display_mutex
00060c04 g DO .bss 00000018 Base _cairo_ft_unscaled_font_map_mutex
00060b8c g DO .bss 00000018 Base
_cairo_pattern_solid_pattern_cache_lock
00060ba4 g DO .bss 00000018 Base
_cairo_pattern_solid_surface_cache_lock
00060bbc g DO .bss 00000018 Base _cairo_font_face_mutex
Other architectures export potentially more.
--- Comment #2 from Sebastian Dröge <slomo@circular-chaos.org> 2008-05-28 02:09:34 PST ---
Created an attachment (id=16784)
--> (http://bugs.freedesktop.org/attachment.cgi?id=16784)
cairo-export-symbols.patch
Better patch that only marks those accidentially exported cairo_.*_mutex
symbols as private.
The other patch might still make sense.
--- Comment #3 from Chris Wilson <chris@chris-wilson.co.uk> 2008-05-28 02:23:43 PST ---
Too slow ;-) Behdad had already fixed it with commit
626edfc333b77604b6955c12ae111d14c174034c.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
cairo-bugs mailing list
cairo-bugs@lists.cairographics.org
http://lists.cairographics.org/mailman/listinfo/cairo-bugs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic