[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo-bugs
Subject:    [cairo-bugs] [Bug 11420] New: cairo "getter" functions should not
From:       bugzilla-daemon () freedesktop ! org
Date:       2007-06-29 20:47:23
Message-ID: bug-11420-4039 () http ! bugs ! freedesktop ! org/
[Download RAW message or body]

http://bugs.freedesktop.org/show_bug.cgi?id=11420

           Summary: cairo "getter" functions should not leave return values
                    uninitialized
           Product: cairo
           Version: 1.5.1
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: cworth@cworth.org
        ReportedBy: cworth@cworth.org
         QAContact: cairo-bugs@cairographics.org


I just noticed that cairo_scaled_font_glyph_extents returns
immediately if scaled_font->status is in an error state.

It should instead fill in the return values with benign results, (0.0
or so).

I think _most_ other getter functions already do that, but it's worth
auditing all of them to check. (And probably worth writing a test to
try to exercise as much of this as possible---we do want to improve
test coverage anyway.)

-Carl


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
_______________________________________________
cairo-bugs mailing list
cairo-bugs@cairographics.org
http://lists.freedesktop.org/mailman/listinfo/cairo-bugs
[prev in list] [next in list] [prev in thread] [next in thread]