[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    Re: [cairo] Time for a release ?
From:       Uli Schlachter <psychon () znc ! in>
Date:       2020-09-25 15:26:40
Message-ID: 96137669-b68d-8ded-eb2a-93d510f41d0f () znc ! in
[Download RAW message or body]

Hi,

Am 25.09.20 um 16:45 schrieb Stanisław Jeśmanowicz:
> Function _cairo_image_surface_is_size_valid() should be removed, because
> pixmap library have enough checks in pixman_image_create_bit()
> to decide if width and height is valid or not.

as I wrote before: That patch is incorrect. Drawing to an image with a
width or height larger than 2^16 does not always work. To quote from the
comment that you are removing:

"This is mainly determined by coordinates of things sent to pixman at
the moment being in 16.16 format."

For the other random stuff that your patch contains:
cairo_surface_map-to_image() never returns NULL (and I have no clue
about bfd).

Cheers,
Uli
-- 
- Buck, when, exactly, did you lose your mind?
- Three months ago. I woke up one morning married to a pineapple.
  An ugly pineapple... But I loved her.
-- 
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo

[prev in list] [next in list] [prev in thread] [next in thread]