[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    Re: [cairo] [PATCH 1/3] Windows: Use DOS path separators in Makefile
From:       Dave Yeo <dave.r.yeo () gmail ! com>
Date:       2019-12-20 18:37:27
Message-ID: 8f16a417-adb7-6356-faa0-2d2139a700d4 () gmail ! com
[Download RAW message or body]

On 12/20/19 10:16 AM, Simon Richter wrote:
> Hi,
>
> On 20.12.19 18:33, Dave Yeo wrote:
>
>> Does Windows still not understand / as a path separator?
>
> It does, IIRC that change was needed because cl.exe interpreted part of
> the path as a switch otherwise, and got confused.

Yea, here it has to start with a drive letter, X:/foo/cairo works, 
/foo/cairo fails.

>
>> What happens if someone invokes this with SHELL=sh.exe or
>> MAKESHELL=sh.exe? Perhaps the \ should be escaped like \\ ?
>
> It has been a while since I tried that by accident, because sh.exe has
> horrible start up time (increases build time by a factor of ten), but
> IIRC it worked.

Ok, here you can get x:foocairo instead of x:\foo\cairo without escaping 
the backslashes but the default is sh.exe and different sh.exe's can be 
different.

>
>> I don't know Windows too well but on OS/2 which is DOSish, these are
>> considerations.
>
> Is that going to be built using Makefile.win32?

No, this just stuck out to me. Perhaps Makefile.win32 should have a 
SHELL=cmd.exe statement?
Anyways actual Windows users can decide.

>
> Is there some infrastructure for testing this on more architectures?

Not that I know of and it is likely dependent on how your environment is 
set up.
Anyways, as I said, Windows users need to review.
Dave
-- 
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo
[prev in list] [next in list] [prev in thread] [next in thread]