[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    Re: [cairo] [PATCH] Fix Windows build with cmd.exe as shell
From:       Simon Richter <Simon.Richter () hogyros ! de>
Date:       2015-04-23 22:27:52
Message-ID: 553971E8.5010006 () hogyros ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

On 23.04.2015 23:42, Bryce Harrington wrote:

>> No, the call is needed because I need to process the arguments (md and=

>> del do not handle forward slashes and echo needs a dot to print a
>> newline instead of "@ECHO is off".

> Well, in any case, the hacky looking echo statements that the call
> syntax creates makes the patch kind of a non-starter for me.  The goal
> sounds noble enough though, so I'd consider another patch that was less=

> invasive.

The bulk of the patch is in an automatically generated file that creates
a file on demand, this entire construct could be replaced by simply
copying a file into place.

The remaining instances are messages printed to the console, this could
be hacked around using $(info ...) and a sub-make -- but I think that is
even worse.

The difference in quote handling would only allow writing the messages
surrounded by quotes, and these could be arranged to form a frame around
the message.

For the directory creation and file deletion I don't see a way around
the call syntax though, because of the processing required.

   Simon


["signature.asc" (application/pgp-signature)]
[Attachment #6 (text/plain)]

-- 
cairo mailing list
cairo@cairographics.org
http://lists.cairographics.org/mailman/listinfo/cairo

[prev in list] [next in list] [prev in thread] [next in thread]