[prev in list] [next in list] [prev in thread] [next in thread] 

List:       c-client
Subject:    bug in imap-2004.RC7
From:       "Daniel A. Steffen" <steffen () ics ! mq ! edu ! au>
Date:       2004-03-01 12:31:22
Message-ID: 592ADCE8-6B7C-11D8-9590-000A958518E8 () maths ! mq ! edu ! au
[Download RAW message or body]

Hi,

found a small bug in tcp_aopen() in 
imap-2004.RC7/src/osdep/unix/tcp_unix.c:

for non-numeric host addresses, the 'host' variable is never 
initialized with 'mb->host' which causes rimapd connections to always 
fail.

the attached patch fixes the problem

Cheers,

Daniel

-- 
** Daniel A. Steffen     **  "And now for something completely
** Dept. of Mathematics  **   different"    Monty Python
** Macquarie University  **  <mailto:steffen@maths.mq.edu.au>
** NSW 2109 Australia    **  <http://www.maths.mq.edu.au/~steffen/>


--Apple-Mail-6-1052834591
Content-Disposition: attachment;
	filename=tcp_unix.patch
Content-Transfer-Encoding: base64
Content-Type: application/applefile;
	name="tcp_unix.patch"

AAUWBwACAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAAJAAAAPgAAAAoAAAADAAAASAAAAA4AAAACAAAA
VgAAAX5URVhUUipjaAAAdGNwX3VuaXgucGF0Y2gAAAEAAAABTAAAAEwAAAAyAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAASAAJUHJvRm9udAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABgAIAG4AKAPAAqgAbgAoA8AC
qLxpdOIAAAJVAAACVQAAAAABAAAAAQAAAAFMAAAATAAAADIAW/CQBxMAAAAcADIAAE1QU1IAAAAK
A+3//wAAAAABPpF0

--Apple-Mail-6-1052834591
Content-Disposition: attachment;
	filename=tcp_unix.patch
Content-Transfer-Encoding: quoted-printable
Content-Type: application/text;
	x-mac-creatorR2A6368;
	x-unix-mode44;
	x-mac-typeT455854;
	name="tcp_unix.patch"

diff -rup orig/imap-2004.RC7/src/osdep/unix/tcp_unix.c imap-2004.RC7/src/osdep/unix/tcp_unix.c
--- orig/imap-2004.RC7/src/osdep/unix/tcp_unix.c	Sat Feb 21 09:42:01 2004
+++ imap-2004.RC7/src/osdep/unix/tcp_unix.c	Mon Mar  1 22:00:57 2004
@@ -337,7 +337,10 @@ TCPSTREAM *tcp_aopen (NETMBX *mb,char *s
       return NIL;
     }
   }
-  else if ((s = tcp_canonical (host)) != host) strcpy (host,s);
+  else {
+    strcpy (host,mb->host);
+    if ((s = tcp_canonical (host)) != host) strcpy (host,s);
+  }
 
   if (*service == '*')		/* build ssh command */
     sprintf (tmp,sshcommand,sshpath,host,

--Apple-Mail-6-1052834591--

-- 
------------------------------------------------------------------
 For information about this mailing list, and its archives, see: 
 http://www.washington.edu/imap/c-client-list.html
------------------------------------------------------------------

[prev in list] [next in list] [prev in thread] [next in thread]