[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox-cvs
Subject:    [git commit] hush: make comment more clear
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2020-12-27 15:04:54
Message-ID: 20201227144756.0DD81826DF () busybox ! osuosl ! org
[Download RAW message or body]

commit: https://git.busybox.net/busybox/commit/?id=c7ef8187688b0e7f92d19b3fed2c4ecffe39a688
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---
 shell/hush.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/shell/hush.c b/shell/hush.c
index f9a295e8d..f5cbbc39f 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -6694,12 +6694,13 @@ static NOINLINE int expand_one_var(o_string *output, int n,
 			 *
 			 * Word-splitting and single quote behavior:
 			 *
-			 * $ f() { for i; do echo "|$i|"; done; };
+			 * $ f() { for i; do echo "|$i|"; done; }
 			 *
-			 * $ x=; f ${x:?'x y' z}
-			 * bash: x: x y z              #BUG: does not abort, ${} results in empty expansion
+			 * $ x=; f ${x:?'x y' z}; echo $?
+			 * bash: x: x y z       # neither f nor "echo $?" executes
+			 * (if interactive, bash does not exit, but merely aborts to prompt. $? is set to 1)
 			 * $ x=; f "${x:?'x y' z}"
-			 * bash: x: x y z       # dash prints: dash: x: 'x y' z   #BUG: does not abort, ${} results in ""
+			 * bash: x: x y z       # dash prints: dash: x: 'x y' z
 			 *
 			 * $ x=; f ${x:='x y' z}
 			 * |x|
_______________________________________________
busybox-cvs mailing list
busybox-cvs@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox-cvs
[prev in list] [next in list] [prev in thread] [next in thread]