[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Huge performance boost for recursion (cp, du, find, ls, rm, , mv)
From:       Rolf Eike Beer <eb () emlix ! com>
Date:       2024-04-16 6:59:22
Message-ID: 4912893.31r3eYUQgx () devpool47 ! emlix ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Montag, 15. April 2024 17:14:11 MESZ Jody Bruchon wrote:
> With these changes, 'busybox find .' and 'busybox find libbb' fail
> entirely, with 'libbb' becoming 'libb' instead. Running 'busybox find
> libbb/' works but the result has double-slashes: 'libbb//whatever.c'.
> The last char of the parameter passed to 'find' is being erased if there
> is no slash.

This line is wrong:

> if (last_char_is_fast(path, '/', pathlen) == NULL) pathlen--;

If you replace "==" with "!=" it works.

Regard,

Eike
-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner
["signature.asc" (application/pgp-signature)]

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]