[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [V2 PATCH] crond: log5 fix typo, replace log level '4' with '5'
From:       Jones Syue 薛懷宗 <jonessyue () qnap ! com>
Date:       2024-02-01 3:17:09
Message-ID: SI2PR04MB50970F29DFA4EFCBB621B666DC432 () SI2PR04MB5097 ! apcprd04 ! prod ! outlook ! com
[Download RAW message or body]

Found previous patch accidentally adds 'x' permission to file 'crond.c',
attached v2 patch would not change permissions of file 'crond.c', 
thank you :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.

["v2-crond-log5.txt" (text/plain)]

From c47cc51d53d1781d615eb27bb57e242ef9842474 Mon Sep 17 00:00:00 2001
From: Jones Syue <jonessyue@qnap.com>
Date: Thu, 1 Feb 2024 11:06:49 +0800
Subject: [PATCH] crond: log5 fix typo, replace log level '4' with '5'

log5() with crondlog(5, msg, va) seems making logging more consistent.

~/git/busybox/scripts/bloat-o-meter ~/busybox_{orig,fix}
function                                             old     new   delta
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0)                 Total: 0 bytes

Signed-off-by: Jones Syue <jonessyue@qnap.com>
---
 miscutils/crond.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/miscutils/crond.c b/miscutils/crond.c
index 3bbb5ac..b3762d3 100644
--- a/miscutils/crond.c
+++ b/miscutils/crond.c
@@ -190,7 +190,7 @@ static void log5(const char *msg, ...)
 {
 	va_list va;
 	va_start(va, msg);
-	crondlog(4, msg, va);
+	crondlog(5, msg, va);
 	va_end(va);
 }
 
-- 
2.1.4



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]