[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    set icmp_code always to 0 even when -p option is used
From:       Felix Schladt <felix.schladt () gmail ! com>
Date:       2023-06-05 17:46:02
Message-ID: 20230605174626.65187-1-felix.schladt () gmail ! com
[Download RAW message or body]

Introduced with commit b34266b42b5f6f78b7346c9ca90caebcd59db345 the icmp_code field \
is no longer set to 0 due to the introduction of a memset of the whole struct to 0. \
But with commit 6ff055115798166e172039284448be758b04e195 the "-p" option was \
introduced, which allows to fill empty bytes of the package with an arbitrary byte. \
Since then the memset sets the whole struct to this byte and then fills in the \
individual fields, but the icmp_code field is never set to 0 as this line is \
commented out.

Kind regards,

Felix Schladt


_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]