[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] mount: add option to disable NFS completely
From:       Reimu <reimu () sudomaker ! com>
Date:       2023-05-25 14:47:45
Message-ID: 91156831-3cd5-d4dd-8cc3-fa573e6f8e64 () sudomaker ! com
[Download RAW message or body]


On 2023/5/25 22:17, David Laight wrote:
> From: Reimu
>> Sent: 25 May 2023 15:04
>>
>> This can save up to ~40 kbytes with uclibc and it helps a lot when
>> you're building a very tiny busybox for embedded systems.
>> ---
>>  util-linux/mount.c | 14 +++++++++++++-
>>  1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/util-linux/mount.c b/util-linux/mount.c
>> index 4e65b6b46..1c3e2bf64 100644
>> --- a/util-linux/mount.c
>> +++ b/util-linux/mount.c
>> @@ -77,6 +77,17 @@
>>  //config:    Note that this option links in RPC support from libc,
>>  //config:    which is rather large (~10 kbytes on uclibc).
>>  //config:
>> +//config:config FEATURE_MOUNT_NFS_ALL
>> +//config:    bool "Support mounting NFS file systems on Linux >= 2.6.23"
>> +//config:    default y
>> +//config:    depends on MOUNT
>> +//config:    help
>> +//config:    Enable mounting of NFS file systems on Linux kernels with
>> +//config:    at least version 2.6.23.
> I don't think you need to reference the Linux kernel version.
>
> 	David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)

I only did this bc there's an existing option called FEATURE_MOUNT_NFS and it mentioned

the Linux kernel version and I want to make as few changes as possible. The best option

would obviously be renaming the existing FEATURE_MOUNT_NFS to something like

FEATURE_MOUNT_NFS_LEGACY and make FEATURE_MOUNT_NFS a main switch.

What's your opinion?

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]