[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v3] udhcpc(6): add -K option to set kernel packet priority
From:       Pacien TRAN-GIRARD <dzfkct.busyboxml () pacien ! net>
Date:       2023-04-13 12:07:07
Message-ID: 168138762754.1656295.12624125235575222643 () mail ! pacien ! net
[Download RAW message or body]

Quoting Clément Péron (2023-04-13 13:13:41)
> > +#if ENABLE_FEATURE_UDHCPC_SK_PRIO
> > +       if (setsockopt_SOL_SOCKET_int(fd, SO_PRIORITY, sk_prio) < 0) {
> 
> One difference is that it will call setsockopt even when sk_prio is
> not set and default to '0'.
> 
> I don't know if this can have an impact, or maybe we should default
> sk_prio to -1 and only call setsockopt_SOL_SOCKET_int() when it's >= 0

I omitted the check here since the default kernel packet priority is 0,
so setting it again to 0 by default should not do any harm.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]