[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] find: implement -ok
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2023-03-28 16:13:29
Message-ID: CAK1hOcOs7f0ovGCy50WUCLCts-C=R=Cm2jP5QSxpBv+QNN4b-g () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jan 29, 2023 at 3:14 AM David Leonard
<d+busybox@adaptive-enterprises.com> wrote:
> Resending patch for 'find -ok'. I re-ran bloatcheck (x86_64).

findutils/find.c: In function ‘do_exec':
findutils/find.c:837:12: error: ‘rc' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
  837 |  return rc == 0; /* return 1 if exitcode 0 */
      |         ~~~^~~~

This is indeed the case (rc is used uninitialized).

> +testing "find -ok" \
> +       "cd find.tempdir && find testfile -ok true {} + 2>&1; echo \$?" \
> +       "true testfile ?\n0\n" \
> +       "" "y"

The test actually failed (extra "\n").

"-ok CMD +" is not accepted by GNU findutils 4.9.0>

Fixing the test.

Applied the result. Thank you.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]