[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ntpd: make NTP client Y2036-ready
From:       Miroslav Lichvar <mlichvar () redhat ! com>
Date:       2022-05-09 17:14:19
Message-ID: YnlL67UjwpYTLQcV () localhost
[Download RAW message or body]

On Tue, May 10, 2022 at 12:50:11AM +0800, Kang-Che Sung wrote:
> On Monday, May 9, 2022, Miroslav Lichvar <mlichvar@redhat.com> wrote:
> > The 32-bit integer part of the NTP timestamp overflows in year 2036,
> > which starts the second NTP era.
> >
> > Modify the timestamp conversion to shift values between 1900-1970 (in
> > the first era) to the second era to enable the client to synchronize
> > correctly until year 2106 (assuming 64-bit time_t).
> >
> > Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
> 
> Is this the right fix where there is no check on the era number?

What exactly would you want to check? The era number is not needed in
the conversion until it's exchanged in the protocol (as was proposed
for NTPv5). For now, it can only cover an interval of 2**32
seconds convering some part of two adjacent eras.

-- 
Miroslav Lichvar

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]