[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v2] Improve support for long options to grep
From:       Walter Lozano <walter.lozano () collabora ! com>
Date:       2022-01-26 19:12:59
Message-ID: 86bc00ba-ae3e-5f45-0b33-28c7bdac8f56 () collabora ! com
[Download RAW message or body]



On 1/26/22 15:38, Xabier Oneca -- xOneca wrote:
> Hi Walter,
> 
>      > There is also unnecessary duplication of source code.
>      >
>      > Just use a #define and C string concatenation to add the extra
>      > long option strings.
> 
>     Yes, I totally agree you. However I used this approach since a previous
>     patch I submitted was rewritten in this way [1] when applying to master.
> 
> 
> Maybe a better approach is to always use getopt32long, as it is 
> converted to getopt32 if LONG_OPTS is not enabled. Maybe Denys forgot 
> about this.
> See libbb.h: https://git.busybox.net/busybox/tree/include/libbb.h#n1351 
> <https://git.busybox.net/busybox/tree/include/libbb.h#n1351>

Thank you for the pointer. Yes, it looks much cleaner to always use 
getopt32long, not sure if there was some reason I'm not aware to try to 
avoid it.

-- 
Walter Lozano
Collabora Ltd.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]