[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    RE: return type demotion remarks
From:       David Laight <David.Laight () ACULAB ! COM>
Date:       2021-11-28 19:51:52
Message-ID: 31ea4b1ae0cb4366bab174fa8f117edc () AcuMS ! aculab ! com
[Download RAW message or body]

From: Bernhard Reutner-Fischer
> Sent: 28 November 2021 19:37
> 
> On Sun, 28 Nov 2021 18:00:31 +0000
> David Laight <David.Laight@ACULAB.COM> wrote:
> 
> > From: Bernhard Reutner-Fischer
> > > Sent: 27 November 2021 20:57
> > >
> > > Hi!
> > >
> > > I'm attaching a color log of some spots that may benefit of using
> > > narrower return types; See "could return".
> >
> > My mailer won't expand a .gz file .....
> 
> yea, it was too big to send uncompressed, sorry for that.
> >
> > However making function arguments and return values smaller
> > than a normal cpu register (long is probably better than int!)
> > is likely to increase code size.
> 
> Arches will promote types as they see fit anyway.

The problem is that the values start needing to be masked to the
smaller type, not that they get promoted.

> I'm attaching something that i would _not_ apply since it was based off
> the user-visible fix-it not taking into account the shifts needed in
> the callers.
> Lessons learned in this v0.0:
> - iterate_on_dir callback should be void
> - find ACTF could use a narrower type
> - functors are a bit of a pain ;)
> cheers,

Try using outlook :-(
It really only wants to execute attachments, not display them.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]