[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell
From: "Roberto A. Foglietta" <roberto.foglietta () gmail ! com>
Date: 2021-09-15 4:16:14
Message-ID: CAJGKYO6ctY0W1VQv-BV8tv7HRLzMsrZFLL0L8idt6MwLaW86rA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Il mar 14 set 2021, 22:01 Denys Vlasenko <vda.linux@googlemail.com> ha
scritto:
> On Tue, Sep 14, 2021 at 3:45 PM Roberto A. Foglietta
> <roberto.foglietta@gmail.com> wrote:
> > Il giorno mar 14 set 2021 alle ore 12:24 Denys Vlasenko
> > <vda.linux@googlemail.com> ha scritto:
> > > > > I am going to replace every raise_exception(EXEXIT) with
> exitshell()
> > > > > and to remove the EXEXIT altogether.
> > >
> > > There is only one: in exitcmd(), the handler of "exit" builtin.
> >
> > I think that also here raise_exception(EXEND); should need to be
> > replaced with exitshell() when FUNCNAME patch will be added
> >
> > if (eflag)
> > goto exexit;
> > }
> > if (flags & EV_EXIT) {
> > exexit:
> > raise_exception(EXEND); //<--- exitshell() when FUNCNAME
> > }
>
> Why?
>
>
> > > > It seems to me that EXEXIT does
> > > > > not add any value but complicates things. What's your opinion on
> that?
> > > > > Do you see any possible regression?
> > >
> > > Could work. Can you make this change through dash?
> > > I do not want to diverge here.
> >
> > I can give you the patch for the busybox and then when you apply it
> > you (or me, but better you) can initiate a synchronisation with dash
> > under multiple issues.
>
> The problem with this order is that dash people may disagree and refuse
> the change.
> If we already apply changes to bbox, what then?
>
The problem is to present ourself without something coherent to their
developing team.
FUNCNAME Is important and at least we should include it. While for the
EXEXIT / EXEND we can do different things: cherry-picking or create a
branch for synchronisation.
I opt in for creating a branch for synchronisation and then merge with the
master in case synchronisation will be successful.
>
[Attachment #5 (text/html)]
<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">Il mar 14 set 2021, 22:01 Denys Vlasenko <<a \
href="mailto:vda.linux@googlemail.com">vda.linux@googlemail.com</a>> ha \
scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Sep 14, 2021 at 3:45 PM \
Roberto A. Foglietta<br> <<a href="mailto:roberto.foglietta@gmail.com" \
target="_blank" rel="noreferrer">roberto.foglietta@gmail.com</a>> wrote:<br> > \
Il giorno mar 14 set 2021 alle ore 12:24 Denys Vlasenko<br> > <<a \
href="mailto:vda.linux@googlemail.com" target="_blank" \
rel="noreferrer">vda.linux@googlemail.com</a>> ha scritto:<br> > > > > \
I am going to replace every raise_exception(EXEXIT) with exitshell()<br> > > \
> > and to remove the EXEXIT altogether.<br> > ><br>
> > There is only one: in exitcmd(), the handler of "exit" \
builtin.<br> ><br>
> I think that also here raise_exception(EXEND); should need to be<br>
> replaced with exitshell() when FUNCNAME patch will be added<br>
><br>
> if (eflag)<br>
> goto exexit;<br>
> }<br>
> if (flags & EV_EXIT) {<br>
> exexit:<br>
> raise_exception(EXEND); //<--- exitshell() when FUNCNAME<br>
> }<br>
<br>
Why?<br>
<br>
<br>
> > > It seems to me that EXEXIT does<br>
> > > > not add any value but complicates things. What's your opinion \
on that?<br> > > > > Do you see any possible regression?<br>
> ><br>
> > Could work. Can you make this change through dash?<br>
> > I do not want to diverge here.<br>
><br>
> I can give you the patch for the busybox and then when you apply it<br>
> you (or me, but better you) can initiate a synchronisation with dash<br>
> under multiple issues.<br>
<br>
The problem with this order is that dash people may disagree and refuse<br>
the change.<br>
If we already apply changes to bbox, what then?<br></blockquote></div></div><div \
dir="auto"><br></div><div dir="auto">The problem is to present ourself without \
something coherent to their developing team. </div><div dir="auto"><br></div><div \
dir="auto">FUNCNAME Is important and at least we should include it. While for the \
EXEXIT / EXEND we can do different things: cherry-picking or create a branch for \
synchronisation.</div><div dir="auto"><br></div><div dir="auto">I opt in for creating \
a branch for synchronisation and then merge with the master in case synchronisation \
will be successful.</div><div dir="auto"><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> </blockquote></div></div></div>
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic