[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 0/3] ash: ignoreeof and interactive vs. non-interactive shells
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2021-09-14 6:39:11
Message-ID: CAK1hOcPXTdKt8bXu+3kBT7oWzQrnCuLDYTab__Tok9Phxys_8A () mail ! gmail ! com
[Download RAW message or body]

Applied, thank you.

Patch #3 can have fewer nesting:

                        if (!top || numeof >= 50)
                                break;
                        if (!stoppedjobs()) {
+                               if (!iflag)
+                                       break;
                                if (!Iflag) {
-                                       if (iflag) {
-                                               newline_and_flush(stderr);
-                                       }
+                                       newline_and_flush(stderr);
                                        break;
                                }
                                out2str("\nUse \"exit\" to leave shell.\n");
                        }


On Sun, Sep 12, 2021 at 12:20 PM Ron Yorston <rmy@pobox.com> wrote:
>
> I was holding back my fix for ignoreeof (broken since 2008!) to see
> what upstream dash thought about my changes to EOF handling.
>
> However, it's required to address the problem with stopped jobs
> preventing non-interactive shells from exiting, so here it is.
>
> I've also pulled in a patch from Harald van Dijk's ash derivative
> which handles a similar situation with non-interactive shells when
> ignoreeof is set.
>
> Ron
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]