[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: v1.33.0: tc(8): "dev" keyword: argv off-by-one, false code flow
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2021-07-11 12:53:29
Message-ID: CAK1hOcOzgkW+oGZtfWs=b+N7+qatndJwoQHjr99h5B7Ue9DrAQ () mail ! gmail ! com
[Download RAW message or body]

Applied, thanks

On Fri, Jul 9, 2021 at 12:14 AM Steffen Nurpmeso <steffen@sdaoden.eu> wrote:
>
> Hello again.
>
>   #?0|kent:~# tc qdisc show dev browse
>   qdisc noqueue 0: root refcnt 2
>   #?0|kent:~# busybox.static tc qdisc show dev browse
>   tc: invalid argument 'SHELL=/bin/bash' to 'command'
>
> In the "arg == ARG_dev" branch of tc_main(), there is a "continue"
> missing.
>
> diff --git a/networking/tc.c b/networking/tc.c
> index 5106844434..177d50fd65 100644
> --- a/networking/tc.c
> +++ b/networking/tc.c
> @@ -538,6 +538,7 @@ int tc_main(int argc UNUSED_PARAM, char **argv)
>                         msg.tcm_ifindex = xll_name_to_index(dev);
>                         if (cmd >= CMD_show)
>                                 filter_ifindex = msg.tcm_ifindex;
> +                       continue;
>                 } else
>                 if ((arg == ARG_qdisc && obj == OBJ_class && cmd >= CMD_show)
>                  || (arg == ARG_handle && obj == OBJ_qdisc && cmd == CMD_change)
>
> --steffen
> |
> |Der Kragenbaer,                The moon bear,
> |der holt sich munter           he cheerfully and one by one
> |einen nach dem anderen runter  wa.ks himself off
> |(By Robert Gernhardt)
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]