[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] httpd: code shrink
From:       Xabier Oneca  --  xOneca <xoneca () gmail ! com>
Date:       2020-11-27 22:21:53
Message-ID: CACkgH71U3jQ1geiCtKYvo0o53QmGkxqVF6RG9qzfC6eHTMedAw () mail ! gmail ! com
[Download RAW message or body]

Hi Denys,

> On Tue, Oct 6, 2020 at 8:36 PM Xabier Oneca -- xOneca <xoneca@gmail.com> wrote:
> > Hi Bruno,
> > > If I understand correctly:
> > > 
> > > decode_base64() from uuencode.c = bigger one
> > > decodeBase64(char *Data) from httpd.c = smaller one
> > 
> > You understood it right. :)
> > 
> > > Assuming they are equivalent (I didn't check), wouldn't it make more sense to:
> > > a. Do the check in uuencode.c to see if httpd.c is used and call the httpd one \
> > > (smaller of the two) in the uudecode/base64 applets?
> > 
> > They are not the same. httpd's decodeBase64() does not have to deal
> > with NULL bytes. Any NULL byte will be treated as the end of the
> > decoded string.
> 
> Actually... httpd.c version is faster and smaller. With some tweaks
> it can be made to deal with NULs correctly (and disallow e.g. "==ZZ"
> or truncated inputs).

https://git.busybox.net/busybox/commit/?id=170b8628fabff2d81606cac052a35f8cf91cc7b2

libbb: smaller and faster decode_base64()
function                                             old     new   delta
decode_base64                                        195     180     -15

Nice! You did what I really wanted from the beginning, but was very
lazy to do right! :P

Xabier Oneca_,,_
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]