[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ifupdown: basic support for bridge_ports
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2020-11-17 10:42:09
Message-ID: CAK1hOcPbH5eGydqDNWB13m-LG13=Mgc9e6mWJ5Y8OHozY23eog () mail ! gmail ! com
[Download RAW message or body]

On Sat, May 9, 2020 at 4:38 PM Joachim Nilsson <troglobit@gmail.com> wrote:
>
> This patch adds basic support for setting up bridges with ifupdown.
> The implementation is limited to listing actual interfaces in the
> bridge_ports attribute of a stanza in /etc/network/interace:
>
>     iface br0 inet static
>         address 192.168.1.1
>         netmask 255.255.255.0
>         bridge_ports lan0 lan1
>
> The patch hooks on to the manual method callbacks, adding the bridge
> interface if it's missing and removing it when taking it down.  Like
> the bridge-utils-interfaces extension of ifupdown in Debian does.

Is it compatible with Debian extension?


> The patch takes care to support ifconfig, ip link/addr and the brctl
> tool depending on the BusyBox config.
>
> Other bridge_ attributes, as well as regexp ifname matching for the
> bridge_ports attribute can be added later.
>
> Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> ---
>  networking/ifupdown.c | 215 +++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 194 insertions(+), 21 deletions(-)
>
> diff --git a/networking/ifupdown.c b/networking/ifupdown.c
> index 60ceb5a1f..c4f20bec2 100644
> --- a/networking/ifupdown.c
> +++ b/networking/ifupdown.c
> @@ -138,6 +138,7 @@
>  //usage:     "\n       -v      Print out what would happen before doing it"
>  //usage:     "\n       -f      Force deconfiguration"
>
> +#include <stdarg.h>

Unnecessary, libbb.h includes it
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]