[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] syslogd: delay PID file creation until syslogd is ready
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2020-11-16 11:13:22
Message-ID: CAK1hOcOxkcqSRP1cvZ9eS9hFhETyMHOfaU1CiFV2m_shLh0zxQ () mail ! gmail ! com
[Download RAW message or body]

Applied, thank you

On Sat, May 9, 2020 at 4:49 PM Joachim Nilsson <troglobit@gmail.com> wrote:
>
> This patch moves the creation of the PID file until after syslogd has
> set up signal handlers and is ready.
>
> Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> ---
>  sysklogd/syslogd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c
> index ab50f4a28..84e6fa5e6 100644
> --- a/sysklogd/syslogd.c
> +++ b/sysklogd/syslogd.c
> @@ -1035,6 +1035,7 @@ static void do_syslogd(void)
>                 kmsg_init();
>
>         timestamp_and_log_internal("syslogd started: BusyBox v" BB_VER);
> +       write_pidfile_std_path_and_ext("syslogd");
>
>         while (!bb_got_signal) {
>                 ssize_t sz;
> @@ -1183,9 +1184,6 @@ int syslogd_main(int argc UNUSED_PARAM, char **argv)
>                 bb_daemonize_or_rexec(DAEMON_CHDIR_ROOT, argv);
>         }
>
> -       //umask(0); - why??
> -       write_pidfile_std_path_and_ext("syslogd");
> -
>         do_syslogd();
>         /* return EXIT_SUCCESS; */
>  }
> --
> 2.25.1
>
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]