[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 3/5] httpd_indexcgi.c: Simplify CSS
From:       Sergey Ponomarev <stokito () gmail ! com>
Date:       2020-07-31 19:55:46
Message-ID: CADR0UcUedE_M+spaXOm5WgV3YXCBnBMwXmZS5QEZq9ynxF6BMw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


the colors I selected because they are shorter and simpler. We may keep hex
colors instead

On Fri, 31 Jul 2020 at 19:25, Denys Vlasenko <vda.linux@googlemail.com>
wrote:

> On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev <stokito@gmail.com>
> wrote:
> > Divide table to thead, tbody and tfoot as it should be in DOM.
> > Add row hover style.
> > Use short color names.
> >
> > Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
> > ---
> >  networking/httpd_indexcgi.c | 19 ++++++++++++-------
> >  1 file changed, 12 insertions(+), 7 deletions(-)
> >
> > diff --git a/networking/httpd_indexcgi.c b/networking/httpd_indexcgi.c
> > index a94d4983e..b652ba9ff 100644
> > --- a/networking/httpd_indexcgi.c
> > +++ b/networking/httpd_indexcgi.c
> > @@ -55,7 +55,6 @@ httpd_indexcgi.c -o index.cgi
> >  "<style>"                                              \
> >  "table {"                                              \
> >    "width:100%;"                                        \
> > -  "background-color:#fff5ee;"                          \
> >    "border-width:1px;" /* 1px 1px 1px 1px; */           \
> >    "border-spacing:2px;"                                \
> >    "border-style:solid;" /* solid solid solid solid; */ \
> > @@ -76,9 +75,9 @@ httpd_indexcgi.c -o index.cgi
> >    "border-color:black;" /* black black black black; */ \
> >    "white-space:nowrap"                                 \
> >  "}"                                                    \
> > -"tr.hdr { background-color:#eee5de }"                  \
> > -"tr:nth-child(odd) { background-color:#ffffff }"       \
> > -"tr.foot { background-color:#eee5de }"                 \
> > +"thead, tfoot { background-color:olive }"              \
> > +"tbody tr:nth-child(even) { background-color:beige }"  \
> > +"tbody tr:hover {  background-color:ivory }"           \
>
> These colors look not that good to me.
> Can you separate change of colors and change in logic into two patches?
>


-- 
Sergey Ponomarev <https://linkedin.com/in/stokito>, skype:stokito

[Attachment #5 (text/html)]

<div dir="ltr">the colors I selected because they are shorter and simpler. We may \
keep hex colors instead<br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Fri, 31 Jul 2020 at 19:25, Denys Vlasenko &lt;<a \
href="mailto:vda.linux@googlemail.com">vda.linux@googlemail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Jul 10, 2020 \
at 9:50 PM Sergey Ponomarev &lt;<a href="mailto:stokito@gmail.com" \
target="_blank">stokito@gmail.com</a>&gt; wrote:<br> &gt; Divide table to thead, \
tbody and tfoot as it should be in DOM.<br> &gt; Add row hover style.<br>
&gt; Use short color names.<br>
&gt;<br>
&gt; Signed-off-by: Sergey Ponomarev &lt;<a href="mailto:stokito@gmail.com" \
target="_blank">stokito@gmail.com</a>&gt;<br> &gt; ---<br>
&gt;   networking/httpd_indexcgi.c | 19 ++++++++++++-------<br>
&gt;   1 file changed, 12 insertions(+), 7 deletions(-)<br>
&gt;<br>
&gt; diff --git a/networking/httpd_indexcgi.c b/networking/httpd_indexcgi.c<br>
&gt; index a94d4983e..b652ba9ff 100644<br>
&gt; --- a/networking/httpd_indexcgi.c<br>
&gt; +++ b/networking/httpd_indexcgi.c<br>
&gt; @@ -55,7 +55,6 @@ httpd_indexcgi.c -o index.cgi<br>
&gt;   &quot;&lt;style&gt;&quot;                                                      \
\<br> &gt;   &quot;table {&quot;                                                      \
\<br> &gt;      &quot;width:100%;&quot;                                               \
\<br> &gt; -   &quot;background-color:#fff5ee;&quot;                                  \
\<br> &gt;      &quot;border-width:1px;&quot; /* 1px 1px 1px 1px; */                 \
\<br> &gt;      &quot;border-spacing:2px;&quot;                                       \
\<br> &gt;      &quot;border-style:solid;&quot; /* solid solid solid solid; */ \<br>
&gt; @@ -76,9 +75,9 @@ httpd_indexcgi.c -o index.cgi<br>
&gt;      &quot;border-color:black;&quot; /* black black black black; */ \<br>
&gt;      &quot;white-space:nowrap&quot;                                              \
\<br> &gt;   &quot;}&quot;                                                            \
\<br> &gt; -&quot;tr.hdr { background-color:#eee5de }&quot;                           \
\<br> &gt; -&quot;tr:nth-child(odd) { background-color:#ffffff }&quot;           \
\<br> &gt; -&quot;tr.foot { background-color:#eee5de }&quot;                          \
\<br> &gt; +&quot;thead, tfoot { background-color:olive }&quot;                     \
\<br> &gt; +&quot;tbody tr:nth-child(even) { background-color:beige }&quot;   \<br>
&gt; +&quot;tbody tr:hover {   background-color:ivory }&quot;                 \<br>
<br>
These colors look not that good to me.<br>
Can you separate change of colors and change in logic into two patches?<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" \
class="gmail_signature"><div dir="ltr"><div><a href="https://linkedin.com/in/stokito" \
target="_blank">Sergey  Ponomarev</a>,  <font face="arial, helvetica, \
sans-serif"><a>skype:stokito</a></font><br></div></div></div>



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]