[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2019-10-14 10:52:24
Message-ID: CAK1hOcM_qCdk9E0F4joVSvhGfXHKwr-r4jkFZVi_eEZ4Gtkydg () mail ! gmail ! com
[Download RAW message or body]

On Fri, Oct 11, 2019 at 3:09 PM James Byrne
<james.byrne@origamienergy.com> wrote:
> On 27/08/2019 14:51, James Byrne wrote:
> > On 17/07/2019 16:53, James Byrne wrote:
> >> When crond is built with FEATURE_CROND_SPECIAL_TIMES enabled, it creates
> >> a file called 'crond.reboot' at CONFIG_PID_FILE_PATH, but if
> >> FEATURE_PIDFILE is disabled, this will be an empty string and the file
> >> will be created in the root directory, which is undesirable.
> >>
> >> This commit makes PID_FILE_PATH depend on FEATURE_CROND_SPECIAL_TIMES as
> >> well as FEATURE_PIDFILE so that you get sensible behaviour in crond when
> >> FEATURE_PIDFILE is switched off.
> >>
> >> Signed-off-by: James Byrne <james.byrne@origamienergy.com>
>
> Hi,
>
> I posted this patch back in July, and I still think it's worth applying.


Applied, thanks!
Sorry for the delay.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]