[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] udhcpc: fix segmentation fault on empty bin opt
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2019-10-08 13:15:10
Message-ID: CAK1hOcO5ivWHD_6s5_8UG=Em6GG8BKur8nJRGTv3NTOAXp5-DQ () mail ! gmail ! com
[Download RAW message or body]

Applied, thanks

On Wed, Sep 25, 2019 at 2:03 PM Michal Kazior <kazikcz@gmail.com> wrote:
>
> From: Michal Kazior <michal@plume.com>
>
> The following caused udhcpc to segfault:
>   busybox udhcpc -i lo -s /dev/null -x 0x3d:
>
> Signed-off-by: Michal Kazior <michal@plume.com>
> ---
>  networking/udhcp/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/networking/udhcp/common.c b/networking/udhcp/common.c
> index 4a452cdb9..9ec752dfc 100644
> --- a/networking/udhcp/common.c
> +++ b/networking/udhcp/common.c
> @@ -539,7 +539,7 @@ int FAST_FUNC udhcp_str2optset(const char *const_str, void *arg,
>
>                 if (optflag->flags == OPTION_BIN) {
>                         val = strtok(NULL, ""); /* do not split "'q w e'" */
> -                       trim(val);
> +                       if (val) trim(val);
>                 } else
>                         val = strtok(NULL, ", \t");
>                 if (!val)
> --
> 2.22.0
>
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]