[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [PATCH] arpping.c: Fixed a TODO by adding an error message print
From:       Martin Lewis <martin.lewis.x84 () gmail ! com>
Date:       2019-08-06 7:05:43
Message-ID: 1565081115-24620-1-git-send-email-martin.lewis.x84 () gmail ! com
[Download RAW message or body]

Signed-off-by: Martin Lewis <martin.lewis.x84@gmail.com>
---
 networking/udhcp/arpping.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/networking/udhcp/arpping.c b/networking/udhcp/arpping.c
index a395e83..59c2bf8 100644
--- a/networking/udhcp/arpping.c
+++ b/networking/udhcp/arpping.c
@@ -80,8 +80,7 @@ int FAST_FUNC arpping(uint32_t test_nip,
 	memset(&addr, 0, sizeof(addr));
 	safe_strncpy(addr.sa_data, interface, sizeof(addr.sa_data));
 	if (sendto(s, &arp, sizeof(arp), 0, &addr, sizeof(addr)) < 0) {
-		// TODO: error message? caller didn't expect us to fail,
-		// just returning 1 "no reply received" misleads it.
+		bb_perror_msg("can't send arp request on raw socket");
 		goto ret;
 	}
 
-- 
1.9.1

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]