[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] hush: Check special names after export (ex. PS1)
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2019-05-14 16:56:59
Message-ID: CAK1hOcOnuzvSoa-Oa8sF5VKrbanHwwHPAEG=e=5jFOcn3xW7vA () mail ! gmail ! com
[Download RAW message or body]

On Mon, May 13, 2019 at 11:01 PM Catherine Garabedian
<catherine@kubos.co> wrote:
> 
> Package: busybox
> Version: v1.30.1
> Severity: medium
> 
> This patch (attached) causes the special hush variables (PS1, PS2, LINENO, etc) to \
> be updated after an `export` command is performed. 
> This fixes a bug where, when the PS1 variable is updated with `export PS1='# '`, \
> the command line prompt becomes corrupted. This issue is because the pointer to the \
> old PS1 string is freed, but the PS1 global variable isn't updated to contain the \
> pointer to the new PS1 string. This issue was introduced in v1.29.0.
> 
> Without this patch, the issue can be worked around by using `PS1='# '` to update \
> the envar instead of `export PS1='# '`. 
> I have run the tests in the 'testsuite' directory and no new errors were \
> introduced.

Applied, thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]