[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ip: Fix ip -o link
From:       Xabier Oneca  --  xOneca <xoneca () gmail ! com>
Date:       2019-03-31 12:37:47
Message-ID: CACkgH738Hu5cKnMPy6iF7jic2CVPDb9XkEUE+eKU4OMxmw8WKQ () mail ! gmail ! com
[Download RAW message or body]

Hi,

> diff --git a/networking/libiproute/ipaddress.c b/networking/libiproute/ipaddress.c
> index d088caf4c..0a1b5d798 100644
> --- a/networking/libiproute/ipaddress.c
> +++ b/networking/libiproute/ipaddress.c
> @@ -574,8 +574,8 @@ int FAST_FUNC ipaddr_list_or_flush(char **argv, int flush)
>         }
>
>         for (l = linfo; l; l = l->next) {
> -               if (no_link
> -                || (oneline || print_linkinfo(&l->h) == 0)
> +               if ((oneline && G_filter.family != AF_PACKET)
> +                || (print_linkinfo(&l->h) == 0)
>                 /* ^^^^^^^^^ "ip -oneline a" does not print link info */

Now the comment is misplaced. It refers to the oneline test, not the
print_linkinfo. But whatever...

Cheers,

Xabier Oneca_,,_
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]